test: test-run reports wrong source of error #6134
Comments
tsafin
added a commit
to tsafin/tarantool
that referenced
this issue
Jun 8, 2021
It always was a problem that reported source line was not pointing to the actual callee line number, but rather to the start of file, i.e. we have seen: ``` [001] sql-tap/tkt-9a8b09f8e6.test.lua memtx [001] not ok 22 - 4.3 # [001] Traceback: [001] [Lua ] function 'do_catchsql_test' at </home/tsafin/tarantool/test/var/001_sql-tap/sqltester.lua:123> [001] [main] at </home/tsafin/tarantool/test/sql-tap/tkt-9a8b09f8e6.test.lua:0> [001] [001] not ok 23 - 4.4 # [001] Traceback: [001] [Lua ] function 'do_catchsql_test' at </home/tsafin/tarantool/test/var/001_sql-tap/sqltester.lua:123> [001] [main] at </home/tsafin/tarantool/test/sql-tap/tkt-9a8b09f8e6.test.lua:0> ``` (see the :0 part) Instead of correct line numbers: ``` [001] sql-tap/tkt-9a8b09f8e6.test.lua memtx [001] not ok 22 - 4.3 # [001] Traceback: [001] [Lua ] function 'do_catchsql_test' at </home/tsafin/tarantool/test/var/001_sql-tap/sqltester.lua:142> [001] [main] at </home/tsafin/tarantool/test/sql-tap/tkt-9a8b09f8e6.test.lua:242> [001] [001] not ok 23 - 4.4 # [001] Traceback: [001] [Lua ] function 'do_catchsql_test' at </home/tsafin/tarantool/test/var/001_sql-tap/sqltester.lua:142> [001] [main] at </home/tsafin/tarantool/test/sql-tap/tkt-9a8b09f8e6.test.lua:252> ``` The problem was due to `.linedefined` used, instead of source line in `.currentline`. Closes tarantool#6134
tsafin
added a commit
to tsafin/tarantool
that referenced
this issue
Jun 11, 2021
It always was a problem that reported source line was not pointing to the actual callee line number, but rather to the start of file, i.e. we have seen: ``` [001] sql-tap/tkt-9a8b09f8e6.test.lua memtx [001] not ok 22 - 4.3 # [001] Traceback: [001] [Lua ] function 'do_catchsql_test' at </home/tsafin/tarantool/test/var/001_sql-tap/sqltester.lua:123> [001] [main] at </home/tsafin/tarantool/test/sql-tap/tkt-9a8b09f8e6.test.lua:0> [001] [001] not ok 23 - 4.4 # [001] Traceback: [001] [Lua ] function 'do_catchsql_test' at </home/tsafin/tarantool/test/var/001_sql-tap/sqltester.lua:123> [001] [main] at </home/tsafin/tarantool/test/sql-tap/tkt-9a8b09f8e6.test.lua:0> ``` (see the :0 part) Instead of correct line numbers: ``` [001] sql-tap/tkt-9a8b09f8e6.test.lua memtx [001] not ok 22 - 4.3 # [001] Traceback: [001] [Lua ] function 'do_catchsql_test' at </home/tsafin/tarantool/test/var/001_sql-tap/sqltester.lua:142> [001] [main] at </home/tsafin/tarantool/test/sql-tap/tkt-9a8b09f8e6.test.lua:242> [001] [001] not ok 23 - 4.4 # [001] Traceback: [001] [Lua ] function 'do_catchsql_test' at </home/tsafin/tarantool/test/var/001_sql-tap/sqltester.lua:142> [001] [main] at </home/tsafin/tarantool/test/sql-tap/tkt-9a8b09f8e6.test.lua:252> ``` The problem was due to `.linedefined` used, instead of source line in `.currentline`. Closes tarantool#6134
tsafin
added a commit
to tsafin/tarantool
that referenced
this issue
Jun 16, 2021
It always was a problem that reported source line was not pointing to the actual callee line number, but rather to the start of file, i.e. we have seen: ``` [001] sql-tap/tkt-9a8b09f8e6.test.lua memtx [001] not ok 22 - 4.3 # [001] Traceback: [001] [Lua ] function 'do_catchsql_test' at </home/tsafin/tarantool/test/var/001_sql-tap/sqltester.lua:123> [001] [main] at </home/tsafin/tarantool/test/sql-tap/tkt-9a8b09f8e6.test.lua:0> [001] [001] not ok 23 - 4.4 # [001] Traceback: [001] [Lua ] function 'do_catchsql_test' at </home/tsafin/tarantool/test/var/001_sql-tap/sqltester.lua:123> [001] [main] at </home/tsafin/tarantool/test/sql-tap/tkt-9a8b09f8e6.test.lua:0> ``` (see the :0 part) Instead of correct line numbers: ``` [001] sql-tap/tkt-9a8b09f8e6.test.lua memtx [001] not ok 22 - 4.3 # [001] Traceback: [001] [Lua ] function 'do_catchsql_test' at </home/tsafin/tarantool/test/var/001_sql-tap/sqltester.lua:142> [001] [main] at </home/tsafin/tarantool/test/sql-tap/tkt-9a8b09f8e6.test.lua:242> [001] [001] not ok 23 - 4.4 # [001] Traceback: [001] [Lua ] function 'do_catchsql_test' at </home/tsafin/tarantool/test/var/001_sql-tap/sqltester.lua:142> [001] [main] at </home/tsafin/tarantool/test/sql-tap/tkt-9a8b09f8e6.test.lua:252> ``` The problem was due to `.linedefined` used, instead of source line in `.currentline`. Closes tarantool#6134
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It always was a problem that reported source line was not
pointing to the actual callee line number, but rather to
the start of file, i.e. we have seen:
(see the
:0part)Instead of a correct line numbers:
The problem was due to
debug.getinfo.linedefinedused, instead of source line in.currentline.The text was updated successfully, but these errors were encountered: