Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve luajit-gdb.py dumping of light userdata #6481

Closed
Buristan opened this issue Sep 30, 2021 · 0 comments
Closed

Improve luajit-gdb.py dumping of light userdata #6481

Buristan opened this issue Sep 30, 2021 · 0 comments
Assignees
Labels
2.10 Target is 2.10 and all newer release/master branches devtools luajit

Comments

@Buristan
Copy link
Collaborator

There are two things to do:

  1. Handle new format for LJ_64 with full-range 64 bit light userdata.
  2. Fix old format dumping (useful for Tarantool 1.10 debugging) that dumps 32 bits instead the whole address (light userdata @ 0x40affeb0 instead of light userdata @ 0x7f0e40affeb0).
@igormunkin igormunkin added this to the 1.10.12 milestone Oct 5, 2021
@kyukhin kyukhin removed the prio8 label Dec 9, 2021
@kyukhin kyukhin modified the milestones: 1.10.12, 1.10.13 Dec 30, 2021
@kyukhin kyukhin modified the milestones: 1.10.13, 1.10.14 Jun 1, 2022
@igormunkin igormunkin added 1.10 Target is 1.10 and all newer release/master branches and removed teamL labels Sep 15, 2022
@mkokryashkin mkokryashkin self-assigned this Oct 3, 2022
mkokryashkin added a commit to tarantool/luajit that referenced this issue Oct 5, 2022
Following up the introduction of full-range 64-bit lightuserdata
support in commit 2cacfa8 ("Add support for full-range 64 bit
lightuserdata."), this patch modifies the corresponding dumper
behavior for LJ_64 platforms in the luajit-gdb extension.

Resolves tarantool/tarantool#6481
mkokryashkin added a commit to tarantool/luajit that referenced this issue Oct 11, 2022
Following up the introduction of full-range 64-bit lightuserdata
support in commit 2cacfa8 ("Add support for full-range 64 bit
lightuserdata."), this patch modifies the corresponding dumper
behavior for LJ_64 platforms in the luajit-gdb extension.

Resolves tarantool/tarantool#6481
@kyukhin kyukhin removed this from the 1.10.14 milestone Oct 12, 2022
mkokryashkin added a commit to tarantool/luajit that referenced this issue Oct 17, 2022
Following up the introduction of full-range 64-bit lightuserdata
support in commit 2cacfa8 ('Add
support for full-range 64 bit lightuserdata.'), this patch
modifies the corresponding dumper behavior for LJ_64 platforms
in the luajit-gdb extension.

Resolves tarantool/tarantool#6481
mkokryashkin added a commit to tarantool/luajit that referenced this issue Dec 1, 2022
Following up the introduction of full-range 64-bit lightuserdata
support in commit 2cacfa8 ('Add
support for full-range 64 bit lightuserdata.'), this patch
modifies the corresponding dumper behavior for LJ_64 platforms
in the luajit-gdb extension.

Resolves tarantool/tarantool#6481
mkokryashkin added a commit to tarantool/luajit that referenced this issue Dec 1, 2022
Following up the introduction of full-range 64-bit lightuserdata
support in commit 2cacfa8 ('Add
support for full-range 64 bit lightuserdata.'), this patch
modifies the corresponding dumper behavior for LJ_64 platforms
in the luajit-gdb extension.

Resolves tarantool/tarantool#6481
mkokryashkin added a commit to tarantool/luajit that referenced this issue Dec 5, 2022
Following up the introduction of full-range 64-bit lightuserdata
support in commit 2cacfa8 ('Add
support for full-range 64 bit lightuserdata.'), this patch
modifies the corresponding dumper behavior for LJ_64 platforms
in the luajit-gdb extension.

Resolves tarantool/tarantool#6481
igormunkin pushed a commit to tarantool/luajit that referenced this issue Dec 9, 2022
Following up the introduction of full-range 64-bit lightuserdata
support in commit 2cacfa8 ('Add
support for full-range 64 bit lightuserdata.'), this patch
modifies the corresponding dumper behavior for LJ_64 platforms
in the luajit-gdb extension.

Resolves tarantool/tarantool#6481
igormunkin pushed a commit to tarantool/luajit that referenced this issue Dec 9, 2022
Following up the introduction of full-range 64-bit lightuserdata
support in commit 2cacfa8 ('Add
support for full-range 64 bit lightuserdata.'), this patch
modifies the corresponding dumper behavior for LJ_64 platforms
in the luajit-gdb extension.

Resolves tarantool/tarantool#6481

Reviewed-by: Igor Munkin <imun@tarantool.org>
Signed-off-by: Igor Munkin <imun@tarantool.org>
(cherry picked from commit 9c4048d)
@igormunkin igormunkin added 2.10 Target is 2.10 and all newer release/master branches and removed 1.10 Target is 1.10 and all newer release/master branches labels Jan 9, 2023
igormunkin added a commit to igormunkin/tarantool that referenced this issue Jan 10, 2023
* cmake: introduce CheckUnwindTables helper
* x64/LJ_GC64: Fix type-check-only variant of SLOAD.
* LJ_GC64: Fix ir_khash for non-string GCobj.
* gdb: support full-range 64-bit lightuserdata

Relates to tarantool#6481
Part of tarantool#7230

NO_DOC=LuaJIT submodule bump
NO_TEST=LuaJIT submodule bump
igormunkin added a commit to igormunkin/tarantool that referenced this issue Jan 10, 2023
* cmake: introduce CheckUnwindTables helper
* x64/LJ_GC64: Fix type-check-only variant of SLOAD.
* LJ_GC64: Fix ir_khash for non-string GCobj.
* gdb: support full-range 64-bit lightuserdata

Relates to tarantool#6481
Part of tarantool#7230

NO_DOC=LuaJIT submodule bump
NO_TEST=LuaJIT submodule bump
igormunkin added a commit that referenced this issue Jan 11, 2023
* cmake: introduce CheckUnwindTables helper
* x64/LJ_GC64: Fix type-check-only variant of SLOAD.
* LJ_GC64: Fix ir_khash for non-string GCobj.
* gdb: support full-range 64-bit lightuserdata

Relates to #6481
Part of #7230

NO_DOC=LuaJIT submodule bump
NO_TEST=LuaJIT submodule bump
igormunkin added a commit that referenced this issue Jan 11, 2023
* cmake: introduce CheckUnwindTables helper
* x64/LJ_GC64: Fix type-check-only variant of SLOAD.
* LJ_GC64: Fix ir_khash for non-string GCobj.
* gdb: support full-range 64-bit lightuserdata

Relates to #6481
Part of #7230

NO_DOC=LuaJIT submodule bump
NO_TEST=LuaJIT submodule bump
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.10 Target is 2.10 and all newer release/master branches devtools luajit
Projects
None yet
Development

No branches or pull requests

4 participants