Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update luarocks to 3.9.2 #6597

Closed
Totktonada opened this issue Nov 9, 2021 · 2 comments · Fixed by #9184
Closed

Update luarocks to 3.9.2 #6597

Totktonada opened this issue Nov 9, 2021 · 2 comments · Fixed by #9184
Assignees
Labels
2.11 Target is 2.11 and all newer release/master branches 3sp luarocks teamE

Comments

@Totktonada
Copy link
Member

Totktonada commented Nov 9, 2021

Needed to autoreplace git:// with git+https://, see #6587 (comment).

@Totktonada
Copy link
Member Author

See also #6223.

@kyukhin kyukhin added teamL and removed teamL labels Dec 3, 2021
@kyukhin kyukhin added the 5856 label Dec 24, 2021
Totktonada added a commit to tarantool/crud that referenced this issue Apr 4, 2022
GitHub had disabled insecure git clone (see [1]), so we should use
`git+https://` in the rockspec instead of `git://`. The fix is proposed
to the upstream in [2], but is not merged at the moment of writting
this. This patch workarounds the problem on our side.

Recent luarocks (3.8.0) autoreplaces `git://` with `git+https://`, but
we have older luarocks version shipped with tarantool. See [3] for
details.

[1]: https://github.blog/2021-09-01-improving-git-protocol-security-github/
[2]: moteus/luacov-coveralls#30
[3]: tarantool/tarantool#6597
Totktonada added a commit to tarantool/crud that referenced this issue Apr 4, 2022
GitHub had disabled insecure git clone (see [1]), so we should use
`git+https://` in the rockspec instead of `git://`. The fix is proposed
to the upstream in [2], but is not merged at the moment of writting
this. This patch workarounds the problem on our side.

Recent luarocks (3.8.0) autoreplaces `git://` with `git+https://`, but
we have older luarocks version shipped with tarantool. See [3] for
details.

[1]: https://github.blog/2021-09-01-improving-git-protocol-security-github/
[2]: moteus/luacov-coveralls#30
[3]: tarantool/tarantool#6597
@Totktonada Totktonada removed the 5856 label Jun 14, 2022
@LeonidVas LeonidVas added the 3sp label Sep 19, 2022
@DifferentialOrange
Copy link
Member

See also tarantool/cartridge#1834

@locker locker mentioned this issue Sep 26, 2023
@locker locker added the 2.11 Target is 2.11 and all newer release/master branches label Sep 26, 2023
@locker locker changed the title Update luarocks to 3.8.0 (to autoreplace git:// with git+https://) Update luarocks to 3.9.2 (to autoreplace git:// with git+https://) Sep 26, 2023
@locker locker removed the 3sp label Sep 26, 2023
@locker locker changed the title Update luarocks to 3.9.2 (to autoreplace git:// with git+https://) Update luarocks to 3.9.2 Sep 26, 2023
0x501D added a commit to 0x501D/tarantool that referenced this issue Sep 27, 2023
luarocks version updated to version 3.0.2

Closes tarantool#6597

NO_DOC=The engine has been updated, the functionality has not changed
NO_TEST=see NO_DOC
0x501D added a commit to 0x501D/tarantool that referenced this issue Sep 27, 2023
luarocks version updated to version 3.9.2

Closes tarantool#6597

NO_DOC=The engine has been updated, the functionality has not changed
NO_TEST=see NO_DOC
0x501D added a commit to 0x501D/tarantool that referenced this issue Sep 27, 2023
luarocks version updated to version 3.9.2

Closes tarantool#6597

NO_DOC=The engine has been updated, the functionality has not changed
NO_TEST=see NO_DOC
0x501D added a commit to 0x501D/tarantool that referenced this issue Sep 28, 2023
luarocks version updated to version 3.9.2

Closes tarantool#6597

NO_DOC=The engine has been updated, the functionality has not changed
NO_TEST=see NO_DOC
0x501D added a commit to 0x501D/tarantool that referenced this issue Sep 28, 2023
luarocks version updated to version 3.9.2

Closes tarantool#6597

NO_DOC=The engine has been updated, the functionality has not changed
NO_TEST=see NO_DOC
0x501D added a commit to 0x501D/tarantool that referenced this issue Sep 28, 2023
luarocks version updated to version 3.9.2

Closes tarantool#6597

NO_DOC=The engine has been updated, the functionality has not changed
NO_TEST=see NO_DOC
0x501D added a commit to 0x501D/tarantool that referenced this issue Sep 28, 2023
luarocks version updated to version 3.9.2

Closes tarantool#6597

NO_DOC=The engine has been updated, the functionality has not changed
NO_TEST=see NO_DOC
0x501D added a commit to 0x501D/tarantool that referenced this issue Sep 28, 2023
luarocks version updated to version 3.9.2

Closes tarantool#6597

NO_DOC=The engine has been updated, the functionality has not changed
NO_TEST=see NO_DOC
LeonidVas pushed a commit that referenced this issue Sep 28, 2023
luarocks version updated to version 3.9.2

Closes #6597

NO_DOC=The engine has been updated, the functionality has not changed
NO_TEST=see NO_DOC
0x501D added a commit to 0x501D/tarantool that referenced this issue Sep 28, 2023
luarocks version updated to version 3.9.2

Closes tarantool#6597

NO_DOC=The engine has been updated, the functionality has not changed
NO_TEST=see NO_DOC

(cherry picked from commit 1dc8cd8)
LeonidVas pushed a commit that referenced this issue Sep 28, 2023
luarocks version updated to version 3.9.2

Closes #6597

NO_DOC=The engine has been updated, the functionality has not changed
NO_TEST=see NO_DOC

(cherry picked from commit 1dc8cd8)
@LeonidVas LeonidVas added the 3sp label Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.11 Target is 2.11 and all newer release/master branches 3sp luarocks teamE
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants