Cannot use square brackets in procedure resolution for Lua calls #8604

CuriousGeorgiy · 2023-04-25T12:21:30Z

I have the following schema:

box.cfg{}

s = box.schema.space:create('s')
s:create_index('i')

rawset(_G, {bar = function() return 777 end, [777] = function() return 777 end}, 'foo')

The following calls succeed:

nb = require('net.box')

nb.self:call('box.space.s:select')
-- []
nb.self:call('foo.bar')
-- 777

While the following calls return an error:

nb = require('net.box')

nb.self:call('box.space['s']:select')
-- error: Procedure 'box.space['s']:select()' is not defined
nb.self:call('box.space[512]:select')
-- error: Procedure 'box.space[512]:select()' is not defined
nb.self:call('foo[777]')
-- error: Procedure 'foo[777]' is not defined

CuriousGeorgiy · 2023-04-25T12:31:12Z

Requested by @alyapunov.

@TarantoolBot

With the addition of square brackets, procedure resolution for Lua calls is essentially parsing a JSON path ('*' placeholder forbidden) with a special colon case for object methods, which we handle separately: refactor the existing code to reuse JSON lexer. Closes tarantool#8604 @TarantoolBot document Title: JSON paths in procedure resolution for Lua calls With the addition of square brackets to procedure resolution, Lua calls now resolve any JSON path to a procedure. This is applicable to `net.box` connection objects `call` method as well as `box.schema.func.call`. Examples of JSON path function calls are provided in the test.

@TarantoolBot

With the addition of square brackets, procedure resolution for Lua calls is essentially parsing a JSON path ('*' placeholder forbidden) with a special colon case for object methods, which we handle separately: refactor the existing code to reuse JSON lexer. Closes tarantool#8604 @TarantoolBot document Title: JSON paths in procedure resolution for Lua calls With the addition of square brackets to procedure resolution, Lua calls now resolve any JSON path to a procedure. This is applicable to `net.box` connection objects `call` method as well as `box.schema.func.call`. Examples of JSON path function calls are provided in the test.

@TarantoolBot

With the addition of square brackets, procedure resolution for Lua calls is essentially parsing a JSON path ('*' placeholder forbidden) with a special colon case for object methods, which we handle separately: refactor the existing code to reuse JSON lexer. Closes tarantool#8604 @TarantoolBot document Title: JSON paths in procedure resolution for Lua calls With the addition of square brackets to procedure resolution, Lua calls now resolve any JSON path to a procedure. This is applicable to `net.box` connection objects `call` method as well as `box.schema.func.call`. Examples of JSON path function calls are provided in the test.

@TarantoolBot

With the addition of square brackets, procedure resolution for Lua calls is essentially parsing a JSON path ('*' placeholder forbidden) with a special colon case for object methods, which we handle separately: refactor the existing code to reuse JSON lexer. Closes tarantool#8604 @TarantoolBot document Title: square brackets in procedure resolution for Lua calls Square brackets are now supported in Lua call procedure resolution. This is applicable to `net.box` connection objects `call` method as well as `box.schema.func.call`. Examples of function calls with square brackets can be found in the test to this patch.

@TarantoolBot

Add a lexer for parsing parts of Lua procedure call: basically, it's copy-paste of JSON path lexer accounting for differences between JSON paths and Lua procedure calls. Closes tarantool#8604 @TarantoolBot document Title: square brackets in procedure resolution for Lua calls Square brackets are now supported in Lua call procedure resolution. This is applicable to `net.box` connection objects `call` method as well as `box.schema.func.call`. Examples of function calls with square brackets can be found in the test to this patch.

@TarantoolBot

Add a lexer for parsing parts of Lua procedure call: basically, it's copy-paste of JSON path lexer accounting for differences between JSON paths and Lua procedure calls. Closes tarantool#8604 @TarantoolBot document Title: square brackets in procedure resolution for Lua calls Square brackets are now supported in Lua call procedure resolution. This is applicable to `net.box` connection objects `call` method as well as `box.schema.func.call`. Examples of function calls with square brackets can be found in the test to this patch.

@TarantoolBot

Add a lexer for parsing parts of Lua procedure call: basically, it's copy-paste of JSON path lexer accounting for differences between JSON paths and Lua procedure calls. Closes tarantool#8604 @TarantoolBot document Title: square brackets in procedure resolution for Lua calls Square brackets are now supported in Lua call procedure resolution. This is applicable to `net.box` connection objects `call` method as well as `box.schema.func.call`. Examples of function calls with square brackets can be found in the test to this patch.

@TarantoolBot

Add a lexer for parsing parts of Lua procedure call: basically, it's copy-paste of JSON path lexer accounting for differences between JSON paths and Lua procedure calls. Closes tarantool#8604 @TarantoolBot document Title: square brackets in procedure resolution for Lua calls Square brackets are now supported in Lua call procedure resolution. This is applicable to `net.box` connection objects `call` method as well as `box.schema.func.call`. Examples of function calls with square brackets can be found in the test to this patch.

@TarantoolBot

Add a lexer for parsing parts of Lua procedure call: basically, it's copy-paste of JSON path lexer accounting for differences between JSON paths and Lua procedure calls. Closes tarantool#8604 @TarantoolBot document Title: square brackets in procedure resolution for Lua calls Square brackets are now supported in Lua call procedure resolution. This is applicable to `net.box` connection objects `call` method as well as `box.schema.func.call`. Examples of function calls with square brackets can be found in the test to this patch.

@TarantoolBot

Add a lexer for parsing parts of Lua procedure call: basically, it's copy-paste of JSON path lexer accounting for differences between JSON paths and Lua procedure calls. Closes tarantool#8604 @TarantoolBot document Title: square brackets in procedure resolution for Lua calls Square brackets are now supported in Lua call procedure resolution. This is applicable to `net.box` connection objects `call` method as well as `box.schema.func.call`. Examples of function calls with square brackets can be found in the test to this patch.

@TarantoolBot

Add a lexer for parsing parts of Lua procedure call: basically, it's copy-paste of JSON path lexer accounting for differences between JSON paths and Lua procedure calls. Closes tarantool#8604 @TarantoolBot document Title: square brackets in procedure resolution for Lua calls Square brackets are now supported in Lua call procedure resolution. This is applicable to `net.box` connection objects `call` method as well as `box.schema.func.call`. Examples of function calls with square brackets can be found in the test to this patch.

@TarantoolBot

Add a lexer for parsing parts of Lua procedure call: basically, it's copy-paste of JSON path lexer accounting for differences between JSON paths and Lua procedure calls. Closes tarantool#8604 @TarantoolBot document Title: square brackets in procedure resolution for Lua calls Square brackets are now supported in Lua call procedure resolution. This is applicable to `net.box` connection objects `call` method as well as `box.schema.func.call`. Examples of function calls with square brackets can be found in the test to this patch.

@TarantoolBot

Add a lexer for parsing parts of Lua procedure call: basically, it's copy-paste of JSON path lexer accounting for differences between JSON paths and Lua procedure calls. Closes tarantool#8604 @TarantoolBot document Title: square brackets in procedure resolution for Lua calls Square brackets are now supported in Lua call procedure resolution. This is applicable to `net.box` connection objects `call` method as well as `box.schema.func.call`. Examples of function calls with square brackets can be found in the test to this patch.

@TarantoolBot

Add a lexer for parsing parts of Lua procedure call: basically, it's copy-paste of JSON path lexer accounting for differences between JSON paths and Lua procedure calls. Closes tarantool#8604 @TarantoolBot document Title: square brackets in procedure resolution for Lua calls Square brackets are now supported in Lua call procedure resolution. This is applicable to `net.box` connection objects `call` method as well as `box.schema.func.call`. Examples of function calls with square brackets can be found in the test to this patch.

@TarantoolBot

Add a lexer for parsing parts of Lua procedure call: basically, it's copy-paste of JSON path lexer accounting for differences between JSON paths and Lua procedure calls. Closes tarantool#8604 @TarantoolBot document Title: square brackets in procedure resolution for Lua calls Square brackets are now supported in Lua call procedure resolution. This is applicable to `net.box` connection objects `call` method as well as `box.schema.func.call`. Examples of function calls with square brackets can be found in the test to this patch.

@TarantoolBot

Add a lexer for parsing parts of Lua procedure call: basically, it's copy-paste of JSON path lexer accounting for differences between JSON paths and Lua procedure calls. Closes tarantool#8604 @TarantoolBot document Title: square brackets in procedure resolution for Lua calls Square brackets are now supported in Lua call procedure resolution. This is applicable to `net.box` connection objects `call` method as well as `box.schema.func.call`. Examples of function calls with square brackets can be found in the test to this patch.

@TarantoolBot

Add a lexer for parsing parts of Lua procedure call: basically, it's copy-paste of JSON path lexer accounting for differences between JSON paths and Lua procedure calls. Closes tarantool#8604 @TarantoolBot document Title: square brackets in procedure resolution for Lua calls Square brackets are now supported in Lua call procedure resolution. This is applicable to `net.box` connection objects `call` method as well as `box.schema.func.call`. Examples of function calls with square brackets can be found in the test to this patch.

@TarantoolBot

Add a lexer for parsing parts of Lua procedure call: basically, it's copy-paste of JSON path lexer accounting for differences between JSON paths and Lua procedure calls. Closes tarantool#8604 @TarantoolBot document Title: square brackets in procedure resolution for Lua calls Square brackets are now supported in Lua call procedure resolution. This is applicable to `net.box` connection objects `call` method as well as `box.schema.func.call`. Examples of function calls with square brackets can be found in the test to this patch.

@TarantoolBot

Add a lexer for parsing parts of Lua procedure call: basically, it's copy-paste of JSON path lexer accounting for differences between JSON paths and Lua procedure calls. Closes tarantool#8604 @TarantoolBot document Title: square brackets in procedure resolution for Lua calls Square brackets are now supported in Lua call procedure resolution. This is applicable to `net.box` connection objects `call` method as well as `box.schema.func.call`. Examples of function calls with square brackets can be found in the test to this patch.

@TarantoolBot

Add a lexer for parsing parts of Lua procedure call: basically, it's copy-paste of JSON path lexer accounting for differences between JSON paths and Lua procedure calls. Closes tarantool#8604 @TarantoolBot document Title: square brackets in procedure resolution for Lua calls Square brackets are now supported in Lua call procedure resolution. This is applicable to `net.box` connection objects `call` method as well as `box.schema.func.call`. Examples of function calls with square brackets can be found in the test to this patch.

@TarantoolBot

Add a lexer for parsing parts of Lua procedure call: basically, it's copy-paste of JSON path lexer accounting for differences between JSON paths and Lua procedure calls. Closes tarantool#8604 @TarantoolBot document Title: square brackets in procedure resolution for Lua calls Square brackets are now supported in Lua call procedure resolution. This is applicable to `net.box` connection objects `call` method as well as `box.schema.func.call`. Examples of function calls with square brackets can be found in the test to this patch.

@TarantoolBot

Add a lexer for parsing parts of Lua procedure call: basically, it's copy-paste of JSON path lexer accounting for differences between JSON paths and Lua procedure calls. Closes tarantool#8604 @TarantoolBot document Title: square brackets in procedure resolution for Lua calls Square brackets are now supported in Lua call procedure resolution. This is applicable to `net.box` connection objects `call` method as well as `box.schema.func.call`. Examples of function calls with square brackets can be found in the test to this patch.

@TarantoolBot

Fefactor lua name resolution, simplify and comment. Add an ability to specify path with brackets, for example in 'box.space[512]:get' or 'box.space["test"]:get'. Only literals (strings and numbers) are supported. Closes tarantool#8604 @TarantoolBot document Title: square brackets in procedure resolution for Lua calls Square brackets are now supported in Lua call procedure resolution. This is applicable to `net.box` connection objects `call` method as well as `box.schema.func.call`. Examples of function calls with square brackets can be found in the test to this patch.

@TarantoolBot

Fefactor lua name resolution, simplify and comment. Add an ability to specify path with brackets, for example in 'box.space[512]:get' or 'box.space["test"]:get'. Only literals (strings and numbers) are supported. Closes tarantool#8604 @TarantoolBot document Title: square brackets in procedure resolution for Lua calls Square brackets are now supported in Lua call procedure resolution. This is applicable to `net.box` connection objects `call` method as well as `box.schema.func.call`. Examples of function calls with square brackets can be found in the test to this patch.

@TarantoolBot

Fefactor lua name resolution, simplify and comment. Add an ability to specify path with brackets, for example in 'box.space[512]:get' or 'box.space["test"]:get'. Only literals (strings and numbers) are supported. Closes tarantool#8604 @TarantoolBot document Title: square brackets in procedure resolution for Lua calls Square brackets are now supported in Lua call procedure resolution. This is applicable to `net.box` connection objects `call` method as well as `box.schema.func.call`. Examples of function calls with square brackets can be found in the test to this patch.

@TarantoolBot

Fefactor lua name resolution, simplify and comment. Add an ability to specify path with brackets, for example in 'box.space[512]:get' or 'box.space["test"]:get'. Only literals (strings and numbers) are supported. Closes tarantool#8604 @TarantoolBot document Title: square brackets in procedure resolution for Lua calls Square brackets are now supported in Lua call procedure resolution. This is applicable to `net.box` connection objects `call` method as well as `box.schema.func.call`. Examples of function calls with square brackets can be found in the test to this patch.

@TarantoolBot

Fefactor lua name resolution, simplify and comment. Add an ability to specify path with brackets, for example in 'box.space[512]:get' or 'box.space["test"]:get'. Only literals (strings and numbers) are supported. Closes tarantool#8604 @TarantoolBot document Title: square brackets in procedure resolution for Lua calls Square brackets are now supported in Lua call procedure resolution. This is applicable to `net.box` connection objects `call` method as well as `box.schema.func.call`. Examples of function calls with square brackets can be found in the test to this patch.

@TarantoolBot

Fefactor lua name resolution, simplify and comment. Add an ability to specify path with brackets, for example in 'box.space[512]:get' or 'box.space["test"]:get'. Only literals (strings and numbers) are supported. Closes tarantool#8604 @TarantoolBot document Title: square brackets in procedure resolution for Lua calls Square brackets are now supported in Lua call procedure resolution. This is applicable to `net.box` connection objects `call` method as well as `box.schema.func.call`. Examples of function calls with square brackets can be found in the test to this patch.

@TarantoolBot

Fefactor lua name resolution, simplify and comment. Add an ability to specify path with brackets, for example in 'box.space[512]:get' or 'box.space["test"]:get'. Only literals (strings and numbers) are supported. Closes tarantool#8604 @TarantoolBot document Title: square brackets in procedure resolution for Lua calls Square brackets are now supported in Lua call procedure resolution. This is applicable to `net.box` connection objects `call` method as well as `box.schema.func.call`. Examples of function calls with square brackets can be found in the test to this patch.

@TarantoolBot

Fefactor lua name resolution, simplify and comment. Add an ability to specify path with brackets, for example in 'box.space[512]:get' or 'box.space["test"]:get'. Only literals (strings and numbers) are supported. Closes #8604 @TarantoolBot document Title: square brackets in procedure resolution for Lua calls Square brackets are now supported in Lua call procedure resolution. This is applicable to `net.box` connection objects `call` method as well as `box.schema.func.call`. Examples of function calls with square brackets can be found in the test to this patch.

CuriousGeorgiy added bug Something isn't working iproto labels Apr 25, 2023

CuriousGeorgiy self-assigned this Apr 25, 2023

CuriousGeorgiy added feature A new functionality and removed bug Something isn't working labels Apr 25, 2023

CuriousGeorgiy changed the title ~~Cannot use square brackets in box procedure resolution for remote calls~~ Cannot use square brackets in procedure resolution for Lua calls Apr 25, 2023

CuriousGeorgiy mentioned this issue Apr 25, 2023

box: support space and index names in IPROTO requests #8573

Merged

alyapunov mentioned this issue May 16, 2023

box: support brackets in name resolution for Lua calls #8660

Merged

locker added the 3.0 Target is 3.0 and all newer release/master branches label May 16, 2023

alyapunov closed this as completed in #8660 May 18, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cannot use square brackets in procedure resolution for Lua calls #8604

Cannot use square brackets in procedure resolution for Lua calls #8604

CuriousGeorgiy commented Apr 25, 2023 •

edited

CuriousGeorgiy commented Apr 25, 2023

Cannot use square brackets in procedure resolution for Lua calls #8604

Cannot use square brackets in procedure resolution for Lua calls #8604

Comments

CuriousGeorgiy commented Apr 25, 2023 • edited

CuriousGeorgiy commented Apr 25, 2023

CuriousGeorgiy commented Apr 25, 2023 •

edited