New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broken net_box compability between 2.11 and 2.10 #8745
Comments
There's a bug in Tarantool 2.10 because of which it fails to decode an |
The replication and net.box issues are unrelated. I filed the separate issue #8757 for the replication breakages and removed it from this ticket. |
locker
added a commit
to locker/tarantool
that referenced
this issue
Jun 13, 2023
The xrow_decode_* functions are written in such a way that they ignore unknown IPROTO keys. This is required for connectivity between different Tarantool version. However, there's bug in the code connected with the value type checking: we fail if the key is >= iproto_key_MAX. This worked fine as long as we added new IPROTO keys in the middle of the key space, without bumping iproto_key_MAX, but this assumption broke when we added IPROTO_AUTH_TYPE. The issue is exacerbated by the fact that IPROTO_AUTH_TYPE is used by IPROTO_ID, which is sent unconditionally on connect. Let's fix the value type check and add some tests. Notes: - xrow_decode_heartbeat turns out to be unused. Drop it. - Fix the net.box helpers response_body_decode and netbox_decode_table to handle unknown keys and empty body. This is needed to properly decode a response to an injection in tests. - Testing unknown keys in replication requests would be complicated. Instead we add a bunch of unit tests. - Convert the xrow unit test to TAP. Closes tarantool#8745 NO_DOC=bug fix
locker
added a commit
to locker/tarantool
that referenced
this issue
Jun 14, 2023
The xrow_decode_* functions are written in such a way that they ignore unknown IPROTO keys. This is required for connectivity between different Tarantool version. However, there's bug in the code connected with the value type checking: we fail if the key is >= iproto_key_MAX. This worked fine as long as we added new IPROTO keys in the middle of the key space, without bumping iproto_key_MAX, but this assumption broke when we added IPROTO_AUTH_TYPE. The issue is exacerbated by the fact that IPROTO_AUTH_TYPE is used by IPROTO_ID, which is sent unconditionally on connect. Let's fix the value type check and add some tests. Notes: - xrow_decode_heartbeat turns out to be unused. Drop it. - Fix the net.box helpers response_body_decode and netbox_decode_table to handle unknown keys and empty body. This is needed to properly decode a response to an injection in tests. - Testing unknown keys in replication requests would be complicated. Instead we add a bunch of unit tests. - Convert the xrow unit test to TAP. Closes tarantool#8745 NO_DOC=bug fix
locker
added a commit
that referenced
this issue
Jun 15, 2023
The xrow_decode_* functions are written in such a way that they ignore unknown IPROTO keys. This is required for connectivity between different Tarantool version. However, there's bug in the code connected with the value type checking: we fail if the key is >= iproto_key_MAX. This worked fine as long as we added new IPROTO keys in the middle of the key space, without bumping iproto_key_MAX, but this assumption broke when we added IPROTO_AUTH_TYPE. The issue is exacerbated by the fact that IPROTO_AUTH_TYPE is used by IPROTO_ID, which is sent unconditionally on connect. Let's fix the value type check and add some tests. Notes: - xrow_decode_heartbeat turns out to be unused. Drop it. - Fix the net.box helpers response_body_decode and netbox_decode_table to handle unknown keys and empty body. This is needed to properly decode a response to an injection in tests. - Testing unknown keys in replication requests would be complicated. Instead we add a bunch of unit tests. - Convert the xrow unit test to TAP. Closes #8745 NO_DOC=bug fix
locker
added a commit
that referenced
this issue
Jun 15, 2023
The xrow_decode_* functions are written in such a way that they ignore unknown IPROTO keys. This is required for connectivity between different Tarantool version. However, there's bug in the code connected with the value type checking: we fail if the key is >= iproto_key_MAX. This worked fine as long as we added new IPROTO keys in the middle of the key space, without bumping iproto_key_MAX, but this assumption broke when we added IPROTO_AUTH_TYPE. The issue is exacerbated by the fact that IPROTO_AUTH_TYPE is used by IPROTO_ID, which is sent unconditionally on connect. Let's fix the value type check and add some tests. Notes: - xrow_decode_heartbeat turns out to be unused. Drop it. - Fix the net.box helpers response_body_decode and netbox_decode_table to handle unknown keys and empty body. This is needed to properly decode a response to an injection in tests. - Testing unknown keys in replication requests would be complicated. Instead we add a bunch of unit tests. - Convert the xrow unit test to TAP. Closes #8745 NO_DOC=bug fix (cherry picked from commit ee0660b)
locker
added a commit
that referenced
this issue
Jun 15, 2023
The xrow_decode_* functions are written in such a way that they ignore unknown IPROTO keys. This is required for connectivity between different Tarantool version. However, there's bug in the code connected with the value type checking: we fail if the key is >= iproto_key_MAX. This worked fine as long as we added new IPROTO keys in the middle of the key space, without bumping iproto_key_MAX, but this assumption broke when we added IPROTO_AUTH_TYPE. The issue is exacerbated by the fact that IPROTO_AUTH_TYPE is used by IPROTO_ID, which is sent unconditionally on connect. Let's fix the value type check and add some tests. Notes: - xrow_decode_heartbeat turns out to be unused. Drop it. - Fix the net.box helpers response_body_decode and netbox_decode_table to handle unknown keys and empty body. This is needed to properly decode a response to an injection in tests. - Testing unknown keys in replication requests would be complicated. Instead we add a bunch of unit tests. - Convert the xrow unit test to TAP. Closes #8745 NO_DOC=bug fix (cherry picked from commit ee0660b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Originally this issue also reported a replication breakage, but this was moved to the separate issue #8757.
Bug description
After commit 13b0ce9 there is a broken messaging via net_box between tarantool 2.10 and 2.11.
Related versions:
Target: Linux-x86_64-RelWithDebInfo
Build options: cmake . -DCMAKE_INSTALL_PREFIX=/usr/local -DENABLE_BACKTRACE=TRUE
Compiler: GNU-11.3.0
C_FLAGS: -fexceptions -funwind-tables -fasynchronous-unwind-tables -fno-common -fopenmp -msse2 -Wformat -Wformat-security -Werror=format-security -fstack-protector-strong -fPIC -fmacro-prefix-map=/home/kostya/CLionProjects/tarantool-fork=. -std=c11 -Wall -Wextra -Wno-gnu-alignof-expression -fno-gnu89-inline -Wno-cast-function-type
CXX_FLAGS: -fexceptions -funwind-tables -fasynchronous-unwind-tables -fno-common -fopenmp -msse2 -Wformat -Wformat-security -Werror=format-security -fstack-protector-strong -fPIC -fmacro-prefix-map=/home/kostya/CLionProjects/tarantool-fork=. -std=c++11 -Wall -Wextra -Wno-invalid-offsetof -Wno-gnu-alignof-expression -Wno-cast-function-type
Steps to reproduce
This code return error:
Same behaviour with
conn:call
The text was updated successfully, but these errors were encountered: