Inconsistent interval boudaries check

[DifferentialOrange]

datetime.interval allowed range should include boundaries, yet it doesn't.

tarantool> datetime.interval.new{year=11759221}
---
- error: 'builtin/box/console.lua:415: value 11759221 of year is out of allowed range
    [-11759221, 11759221]'
...

Square brackets imply boundaries inclusion, yet the boundaries are excluded.

tarantool/src/lua/datetime.lua

Lines 297 to 301 in ff57f99

	if v > -max and v < max then
	return v
	end
	error(('value %s of %s is out of allowed range [%s, %s]'):
	format(v, txt, -max, max), 4)

At the same time, datetime range check

tarantool/src/lua/datetime.lua

Line 263 in ff57f99

if extra == v or (v >= from and v <= to) then

and C interval range check

tarantool/src/lib/core/datetime.c

Line 695 in ff57f99

return (v < from) ? -1 : (v > to ? +1 : 0);

include boundaries, as expected.

[DifferentialOrange]

Addition and subtraction also respect boundaries

tarantool> datetime.interval.new{year = 11759220} + datetime.interval.new{year = 1}
---
- +11759221 years
...

tarantool> datetime.interval.new{year = 11759220} + datetime.interval.new{year = 2}
---
- error: addition moves value 11759222 of year out of allowed range [-11759221, 11759221]
...

tarantool> datetime.interval.new{year = -11759220} - datetime.interval.new{year = 1}
---
- -11759221 years
...

tarantool> datetime.interval.new{year = -11759220} - datetime.interval.new{year = 2}
---
- error: subtraction moves value -11759222 of year out of allowed range [-11759221,
    11759221]
...

[ArtDu]

More strange behaviour examples:

[DifferentialOrange]

More strange behaviour examples

I had filed a separate issue, follow #8887

[ArtDu]

More strange behaviour examples:

@DifferentialOrange
So the solution hasn't fixed the second picture problem. We can pass from the connector more than limit if connector didn't check boundaries. For example upper limit for year field is 11759221, but I can pass int32. Does Tarantool have to control it?

[DifferentialOrange]

More strange behaviour examples:

@DifferentialOrange So the solution hasn't fixed the second picture problem. We can pass from the connector more than limit if connector didn't check boundaries. For example upper limit for year field is 11759221, but I can pass int32. Does Tarantool have to control it?

And it wasn't expected to, follow #8887 issue and #8888 patch

[ArtDu]

And it wasn't expected to, follow #8887 issue and #8888 patch

Correct me if I'm wrong, but #8888 fix only int32 limit problem but not problem that you can pass more than field limit value(not int32 limit).

[DifferentialOrange]

And it wasn't expected to, follow #8887 issue and #8888 patch

Correct me if I'm wrong, but #8888 fix only int32 limit problem but not problem that you can pass more than field limit value(not int32 limit).

Yeah, it doesn't do anything with encode validation. File a separate issue if you wish.

[ArtDu]

Yeah, it doesn't do anything with encode validation. File a separate issue if you wish.

I'll create a ticket. I'm just curious suddenly may you have a plan or a ticket to fix it somewhere

upd: #8905