Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error in SQL if too big decimal is parsed #9469

Closed
ImeevMA opened this issue Dec 12, 2023 · 0 comments · Fixed by #9470
Closed

Error in SQL if too big decimal is parsed #9469

ImeevMA opened this issue Dec 12, 2023 · 0 comments · Fixed by #9470
Assignees
@ImeevMA
Labels
bug Something isn't working

Comments

@ImeevMA
Copy link
Collaborator

ImeevMA commented Dec 12, 2023

Reproducer:

tarantool> box.execute([[SELECT 111111111111111111111111111111111111111.0;]])
tarantool: ./src/lua/error.c:111: luaT_push_nil_and_error: Assertion `e != NULL' failed.
Aborted (core dumped)

Also:

tarantool> box.execute([[CREATE TABLE T(i DECIMAL PRIMARY KEY DEFAULT(111111111111111111111111111111111111111.0);]])
tarantool: ./src/lib/core/decimal.c:446: decimal_pack: Assertion `tmp == data' failed.
Aborted (core dumped)

The problem was discovered by fuzzer.
@ImeevMA ImeevMA self-assigned this Dec 12, 2023
@ImeevMA ImeevMA added the bug Something isn't working label Dec 12, 2023
ImeevMA added a commit to ImeevMA/tarantool that referenced this issue Dec 12, 2023
@ImeevMA
sql: check result of parsing to decimal
34e3b56 
This patch fixes a crash that can occur when SQL parses a decimal
literal that represents a number greater than or equal to 10^38.

Closes tarantool#9469

NO_DOC=bugfix
ImeevMA added a commit to ImeevMA/tarantool that referenced this issue Dec 12, 2023
@ImeevMA
sql: properly check result of decimal parsing
1fe1521 
This patch fixes a crash that can occur when SQL parses a decimal
literal that represents a number greater than or equal to 10^38.

Closes tarantool#9469

NO_DOC=bugfix
@ImeevMA ImeevMA mentioned this issue Dec 12, 2023
Merged
ImeevMA added a commit to ImeevMA/tarantool that referenced this issue Dec 12, 2023
@ImeevMA
sql: properly check result of decimal parsing
25901eb 
This patch fixes a crash that can occur when SQL parses a decimal
literal that represents a number greater than or equal to 10^38.

Closes tarantool#9469

NO_DOC=bugfix
ImeevMA added a commit to ImeevMA/tarantool that referenced this issue Dec 13, 2023
@ImeevMA
sql: properly check result of decimal parsing
4c7193b 
This patch fixes a crash that can occur when SQL parses a decimal
literal that represents a number greater than or equal to 10^38.

Closes tarantool#9469

NO_DOC=bugfix
ImeevMA added a commit to ImeevMA/tarantool that referenced this issue Dec 14, 2023
@ImeevMA
sql: properly check result of decimal parsing
89a9dfe 
This patch fixes a crash that can occur when SQL parses a decimal
literal that represents a number greater than or equal to 10^38.

Closes tarantool#9469

NO_DOC=bugfix
igormunkin pushed a commit that referenced this issue Dec 19, 2023
@ImeevMA @igormunkin
sql: properly check result of decimal parsing
05551a5 
This patch fixes a crash that can occur when SQL parses a decimal
literal that represents a number greater than or equal to 10^38.

Closes #9469

NO_DOC=bugfix
ImeevMA added a commit to ImeevMA/tarantool that referenced this issue Dec 19, 2023
@ImeevMA
sql: properly check result of decimal parsing
bcbe393 
This patch fixes a crash that can occur when SQL parses a decimal
literal that represents a number greater than or equal to 10^38.

Closes tarantool#9469

NO_DOC=bugfix

(cherry picked from commit 89a9dfe)
ImeevMA added a commit to ImeevMA/tarantool that referenced this issue Dec 19, 2023
@ImeevMA
sql: properly check result of decimal parsing
9091fd2 
This patch fixes a crash that can occur when SQL parses a decimal
literal that represents a number greater than or equal to 10^38.

Closes tarantool#9469

NO_DOC=bugfix

(cherry picked from commit 05551a5)
ImeevMA added a commit to ImeevMA/tarantool that referenced this issue Dec 19, 2023
@ImeevMA
sql: properly check result of decimal parsing
dcc47f5 
This patch fixes a crash that can occur when SQL parses a decimal
literal that represents a number greater than or equal to 10^38.

Closes tarantool#9469

NO_DOC=bugfix

(cherry picked from commit 05551a5)
This was referenced Dec 19, 2023
Merged
Merged
ImeevMA added a commit to ImeevMA/tarantool that referenced this issue Dec 22, 2023
@ImeevMA
sql: properly check result of decimal parsing
ddf457f 
This patch fixes a crash that can occur when SQL parses a decimal
literal that represents a number greater than or equal to 10^38.

Closes tarantool#9469

NO_DOC=bugfix

(cherry picked from commit 05551a5)
igormunkin pushed a commit that referenced this issue Dec 22, 2023
@ImeevMA @igormunkin
sql: properly check result of decimal parsing
450da02 
This patch fixes a crash that can occur when SQL parses a decimal
literal that represents a number greater than or equal to 10^38.

Closes #9469

NO_DOC=bugfix

(cherry picked from commit 05551a5)
igormunkin pushed a commit that referenced this issue Dec 22, 2023
@ImeevMA @igormunkin
sql: properly check result of decimal parsing
f54f59b 
This patch fixes a crash that can occur when SQL parses a decimal
literal that represents a number greater than or equal to 10^38.

Closes #9469

NO_DOC=bugfix

(cherry picked from commit 05551a5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ImeevMA ImeevMA

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sql: properly check result of decimal parsing ImeevMA/tarantool
1 participant
@ImeevMA