Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show meta of active configuration #9780

Closed
ImeevMA opened this issue Mar 7, 2024 · 0 comments · Fixed by #9783
Closed

Show meta of active configuration #9780

ImeevMA opened this issue Mar 7, 2024 · 0 comments · Fixed by #9783
Assignees
Labels
3.1 Target is 3.1 and all newer release/master branches config

Comments

@ImeevMA
Copy link
Collaborator

ImeevMA commented Mar 7, 2024

The meta is currently displayed for the last configuration load, even if was the failed reload. It would be helpful to show the meta for the active configuration as well.

@ImeevMA ImeevMA added config 3.1 Target is 3.1 and all newer release/master branches labels Mar 7, 2024
@ImeevMA ImeevMA self-assigned this Mar 7, 2024
ImeevMA added a commit to ImeevMA/tarantool that referenced this issue Mar 7, 2024
Closes tarantool#9780

@TarantoolBot document
Title: Expansion of `config:info()`

Before this patch, the `meta` field of the `config:info()` function
contained the meta data of the last load, even if it was unsuccessful
reload. This can be inconvenient because if the reload fails, we expect
that the last configuration that was successfully applied is used, but
its metadata was lost.

Now `config:info()` can take one argument — the version of the
information that should be returned by the function. If no arguments are
specified or the argument is the string "v1", the return value has the
same structure as before this fix. If the argument is the string "v2",
the `meta` field in the return value has fields - `active` (meta for the
last successfully applied configuration) and `last` (meta of the last
loaded configuration).
ImeevMA added a commit to ImeevMA/tarantool that referenced this issue Mar 7, 2024
Closes tarantool#9780

@TarantoolBot document
Title: Expansion of `config:info()`

Before this patch, the `meta` field of the `config:info()` function
contained the meta data of the last load, even if it was unsuccessful
reload. This can be inconvenient because if the reload fails, we expect
that the last configuration that was successfully applied is used, but
its metadata was lost.

Now `config:info()` can take one argument — the version of the
information that should be returned by the function. If no arguments are
specified or the argument is the string `v1`, the return value has the
same structure as before. If the argument is the string `v2`, the `meta`
field in the return value has fields - `active` (meta for the last
successfully applied configuration) and `last` (meta of the last loaded
configuration). Currently only these values are accepted.
ImeevMA added a commit to ImeevMA/tarantool that referenced this issue Mar 11, 2024
Closes tarantool#9780

@TarantoolBot document
Title: Expansion of `config:info()`

Before this patch, the `meta` field of the `config:info()` function
contained the meta data of the last load, even if it was unsuccessful
reload. This can be inconvenient because if the reload fails, we expect
that the last configuration that was successfully applied is used, but
its metadata was lost.

Now `config:info()` can take one argument — the version of the
information that should be returned by the function. If no arguments are
specified or the argument is the string `v1`, the return value has the
same structure as before. If the argument is the string `v2`, the `meta`
field in the return value has fields - `active` (meta for the last
successfully applied configuration) and `last` (meta of the last loaded
configuration). Currently only these values are accepted.
ImeevMA added a commit to ImeevMA/tarantool that referenced this issue Mar 11, 2024
Closes tarantool#9780

@TarantoolBot document
Title: Expansion of `config:info()`

Before this patch, the `meta` field of the `config:info()` function
contained the meta data of the last load, even if it was unsuccessful
reload. This can be inconvenient because if the reload fails, we expect
that the last configuration that was successfully applied is used, but
its metadata was lost.

Now `config:info()` can take one argument — the version of the
information that should be returned by the function. If no arguments are
specified or the argument is the string `v1`, the return value has the
same structure as before. If the argument is the string `v2`, the `meta`
field in the return value has fields - `active` (meta for the last
successfully applied configuration) and `last` (meta of the last loaded
configuration). Currently only these values are accepted.
ImeevMA added a commit to ImeevMA/tarantool that referenced this issue Mar 12, 2024
Closes tarantool#9780

@TarantoolBot document
Title: Expansion of `config:info()`

Before this patch, the `meta` field of the `config:info()` function
contained the meta data of the last load, even if it was unsuccessful
reload. This can be inconvenient because if the reload fails, we expect
that the last configuration that was successfully applied is used, but
its metadata was lost.

Now `config:info()` can take one argument — the version of the
information that should be returned by the function. If no arguments are
specified or the argument is the string `v1`, the return value has the
same structure as before. If the argument is the string `v2`, the `meta`
field in the return value has fields - `active` (meta for the last
successfully applied configuration) and `last` (meta of the last loaded
configuration). Currently only these values are accepted.
ImeevMA added a commit to ImeevMA/tarantool that referenced this issue Mar 14, 2024
Closes tarantool#9780

@TarantoolBot document
Title: Expansion of `config:info()`

Before this patch, the `meta` field of the `config:info()` function
contained the meta data of the last load, even if it was unsuccessful
reload. This can be inconvenient because if the reload fails, we expect
that the last configuration that was successfully applied is used, but
its metadata was lost.

Now `config:info()` can take one argument — the version of the
information that should be returned by the function. If no arguments are
specified or the argument is the string `v1`, the return value has the
same structure as before. If the argument is the string `v2`, the `meta`
field in the return value has fields - `active` (meta for the last
successfully applied configuration) and `last` (meta of the last loaded
configuration). Currently only these values are accepted.
Totktonada pushed a commit that referenced this issue Mar 15, 2024
Closes #9780

@TarantoolBot document
Title: Expansion of `config:info()`

Before this patch, the `meta` field of the `config:info()` function
contained the meta data of the last load, even if it was unsuccessful
reload. This can be inconvenient because if the reload fails, we expect
that the last configuration that was successfully applied is used, but
its metadata was lost.

Now `config:info()` can take one argument — the version of the
information that should be returned by the function. If no arguments are
specified or the argument is the string `v1`, the return value has the
same structure as before. If the argument is the string `v2`, the `meta`
field in the return value has fields - `active` (meta for the last
successfully applied configuration) and `last` (meta of the last loaded
configuration). Currently only these values are accepted.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.1 Target is 3.1 and all newer release/master branches config
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant