Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add workflow to check downgrade versions #10135

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

nshy
Copy link
Contributor

@nshy nshy commented Jun 14, 2024

Tarantool has hardcoded list of versions it can downgrade to. This list should consist of all the released versions less than Tarantool version. This workflow helps to make sure we update the list before release.

When run on the commit with release tag it check the list and fail if it misses some released version less than current. In this case we are supposed to update downgrade list (with required downgrade code) and update the release tag.

Closes #8319

@coveralls
Copy link

Coverage Status

coverage: 87.072% (-0.01%) from 87.084%
when pulling 3e24738 on nshy:workflow-for-downgrade-versions
into c06d0d1
on tarantool:master
.

@nshy nshy requested a review from locker June 14, 2024 12:00
tools/check-downgrade-versions.sh Show resolved Hide resolved
.github/workflows/tree.yml Outdated Show resolved Hide resolved
tools/check-downgrade-versions.sh Show resolved Hide resolved
@locker locker assigned nshy and unassigned locker Jun 17, 2024
@nshy nshy force-pushed the workflow-for-downgrade-versions branch from 3e24738 to 854ea4d Compare June 17, 2024 12:52
@coveralls
Copy link

Coverage Status

coverage: 87.114% (+0.008%) from 87.106%
when pulling 854ea4d on nshy:workflow-for-downgrade-versions
into 3d97334
on tarantool:master
.

@nshy nshy force-pushed the workflow-for-downgrade-versions branch from 854ea4d to d3f3f65 Compare June 17, 2024 13:48
@coveralls
Copy link

Coverage Status

coverage: 87.092% (-0.01%) from 87.106%
when pulling d3f3f65 on nshy:workflow-for-downgrade-versions
into 3d97334
on tarantool:master
.

@nshy nshy force-pushed the workflow-for-downgrade-versions branch from d3f3f65 to 2fcb5c3 Compare June 17, 2024 14:05
@coveralls
Copy link

Coverage Status

coverage: 87.107% (+0.001%) from 87.106%
when pulling 2fcb5c3 on nshy:workflow-for-downgrade-versions
into 3d97334
on tarantool:master
.

@nshy nshy force-pushed the workflow-for-downgrade-versions branch 2 times, most recently from acde601 to 06741c6 Compare June 18, 2024 07:38
@nshy
Copy link
Contributor Author

nshy commented Jun 18, 2024

Moved checking downgrade versions to a new downgrade_versions workflow as discussed f2f.

@nshy nshy assigned locker and unassigned nshy Jun 18, 2024
@locker locker assigned nshy and unassigned locker Jun 18, 2024
@coveralls
Copy link

Coverage Status

coverage: 87.115% (-0.01%) from 87.128%
when pulling 06741c6 on nshy:workflow-for-downgrade-versions
into 6d5f1db
on tarantool:master
.

Tarantool has hardcoded list of versions it can downgrade to. This list
should consist of all the released versions less than Tarantool version.
This workflow helps to make sure we update the list before release.

It is run on pushing release tag to the repo, checks the list and fails
if it misses some released version less than current. In this case we
are supposed to update downgrade list (with required downgrade code) and
update the release tag.

Closes tarantool#8319

NO_TEST=ci
NO_CHANGELOG=ci
NO_DOC=ci
@nshy nshy force-pushed the workflow-for-downgrade-versions branch from 06741c6 to f25bf6f Compare June 18, 2024 07:59
@nshy nshy assigned locker and unassigned nshy Jun 18, 2024
@locker locker assigned nshy and unassigned locker Jun 18, 2024
@locker
Copy link
Member

locker commented Jun 18, 2024

@nshy No need to run full-ci on this one, apparently. Just solicit an approval from the devx team and reassign back to me for merge.

@coveralls
Copy link

Coverage Status

coverage: 87.094% (-0.03%) from 87.128%
when pulling f25bf6f on nshy:workflow-for-downgrade-versions
into 6d5f1db
on tarantool:master
.

@foxzi foxzi added the full-ci Enables all tests for a pull request label Jun 19, 2024
Copy link
Member

@foxzi foxzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@nshy nshy assigned locker and unassigned nshy Jun 19, 2024
@locker locker merged commit 6d85634 into tarantool:master Jun 20, 2024
93 checks passed
@locker
Copy link
Member

locker commented Jun 20, 2024

Cherry-picked to 2.11 and 3.1.

@nshy nshy deleted the workflow-for-downgrade-versions branch June 24, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
full-ci Enables all tests for a pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide tool to check that box.schema.downgrade_versions() knows all released Tarantool versions
4 participants