Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

box: feature tuple:format to get a format of a tuple #10136

Merged
merged 1 commit into from
Jun 17, 2024
Merged

box: feature tuple:format to get a format of a tuple #10136

merged 1 commit into from
Jun 17, 2024

Conversation

DerekBum
Copy link
Contributor

This patch adds tuple:format() method to get a format of a tuple.

Closes #10005

@TarantoolBot document
Title: New format method for box.tuple
Product: Tarantool
Since: 3.2

The tuple:format method returns a format of a tuple.

@coveralls
Copy link

Coverage Status

coverage: 87.076% (-0.008%) from 87.084%
when pulling 502961d on DerekBum:DerekBum/gh-10005-tuple-get-format
into c06d0d1
on tarantool:master.

@DerekBum DerekBum force-pushed the DerekBum/gh-10005-tuple-get-format branch from 502961d to 6e0b8a8 Compare June 14, 2024 12:25
@DerekBum DerekBum marked this pull request as ready for review June 14, 2024 12:26
@DerekBum DerekBum requested a review from a team as a code owner June 14, 2024 12:26
oleg-jukovec
oleg-jukovec reviewed Jun 14, 2024
View reviewed changes
test/box/tuple.result Outdated Show resolved Hide resolved
src/box/lua/tuple.c Outdated Show resolved Hide resolved
test/box/tuple.result Outdated Show resolved Hide resolved
@coveralls
Copy link

Coverage Status

coverage: 87.107% (+0.02%) from 87.084%
when pulling 6e0b8a8 on DerekBum:DerekBum/gh-10005-tuple-get-format
into c06d0d1
on tarantool:master.

oleg-jukovec
oleg-jukovec reviewed Jun 14, 2024
View reviewed changes
src/box/lua/tuple.c Outdated Show resolved Hide resolved
sergepetrenko
sergepetrenko requested changes Jun 14, 2024
View reviewed changes
Copy link
Collaborator

@sergepetrenko sergepetrenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

src/box/lua/tuple.c Outdated Show resolved Hide resolved
@DerekBum DerekBum force-pushed the DerekBum/gh-10005-tuple-get-format branch 3 times, most recently from f61f158 to 5c7fb6a Compare June 14, 2024 18:07
@coveralls
Copy link

Coverage Status

coverage: 87.085% (-0.02%) from 87.105%
when pulling b48b8bd on DerekBum:DerekBum/gh-10005-tuple-get-format
into c5b3e59
on tarantool:master.

@coveralls
Copy link

Coverage Status

coverage: 87.107% (+0.002%) from 87.105%
when pulling 5c7fb6a on DerekBum:DerekBum/gh-10005-tuple-get-format
into c5b3e59
on tarantool:master.

@DerekBum DerekBum force-pushed the DerekBum/gh-10005-tuple-get-format branch from 5c7fb6a to 58f2636 Compare June 14, 2024 19:40
@coveralls
Copy link

Coverage Status

coverage: 87.102% (-0.003%) from 87.105%
when pulling 58f2636 on DerekBum:DerekBum/gh-10005-tuple-get-format
into c5b3e59
on tarantool:master.

oleg-jukovec
oleg-jukovec reviewed Jun 14, 2024
View reviewed changes
src/box/lua/tuple.c Outdated Show resolved Hide resolved
@DerekBum DerekBum force-pushed the DerekBum/gh-10005-tuple-get-format branch 2 times, most recently from 4515c87 to 3dadcc9 Compare June 15, 2024 14:01
@coveralls
Copy link

Coverage Status

coverage: 87.075% (-0.03%) from 87.105%
when pulling 3dadcc9 on DerekBum:DerekBum/gh-10005-tuple-get-format
into c5b3e59
on tarantool:master.

oleg-jukovec
oleg-jukovec approved these changes Jun 15, 2024
View reviewed changes
Copy link
Contributor

@oleg-jukovec oleg-jukovec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the patch!

@sergepetrenko sergepetrenko self-assigned this Jun 17, 2024
sergepetrenko
sergepetrenko requested changes Jun 17, 2024
View reviewed changes
Copy link
Collaborator

@sergepetrenko sergepetrenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fixes!
Two comments left and we'll be good to go.

src/box/lua/tuple.c Outdated Show resolved Hide resolved
test/app-luatest/gh_10005_tuple_get_format.lua Outdated Show resolved Hide resolved
@sergepetrenko sergepetrenko removed their assignment Jun 17, 2024
@DerekBum DerekBum force-pushed the DerekBum/gh-10005-tuple-get-format branch from 3dadcc9 to ea3647b Compare June 17, 2024 11:47
@coveralls
Copy link

Coverage Status

coverage: 87.113% (+0.007%) from 87.106%
when pulling ea3647b on DerekBum:DerekBum/gh-10005-tuple-get-format
into 3d97334
on tarantool:master.

sergepetrenko
sergepetrenko approved these changes Jun 17, 2024
View reviewed changes
Copy link
Collaborator

@sergepetrenko sergepetrenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@sergepetrenko sergepetrenko added the full-ci Enables all tests for a pull request label Jun 17, 2024
@sergepetrenko sergepetrenko removed the full-ci Enables all tests for a pull request label Jun 17, 2024
@DerekBum @sergepetrenko
box: feature tuple:format to get a format of a tuple
82677bb 
This patch adds `tuple:format()` method to get a format
of a tuple.

Closes tarantool#10005

@TarantoolBot document
Title: New `format` method for `box.tuple`
Product: Tarantool
Since: 3.2

The `tuple:format` method returns a format of a tuple.
@sergepetrenko sergepetrenko force-pushed the DerekBum/gh-10005-tuple-get-format branch from ea3647b to 82677bb Compare June 17, 2024 15:01
@sergepetrenko sergepetrenko added the full-ci Enables all tests for a pull request label Jun 17, 2024
@coveralls
Copy link

Coverage Status

coverage: 87.115% (+0.009%) from 87.106%
when pulling 82677bb on DerekBum:DerekBum/gh-10005-tuple-get-format
into 3d97334
on tarantool:master.

@sergepetrenko sergepetrenko merged commit 6d5f1db into tarantool:master Jun 17, 2024
93 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleg-jukovec oleg-jukovec oleg-jukovec approved these changes

@sergepetrenko sergepetrenko sergepetrenko approved these changes

@xuniq xuniq xuniq approved these changes

Assignees

@sergepetrenko sergepetrenko

Labels
full-ci Enables all tests for a pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature tuple:format to get a format of a tuple
5 participants
@DerekBum @coveralls @oleg-jukovec @sergepetrenko @xuniq