[backport 3.1] config: use vshard-ee if available #10144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usage example:
```lua
local loaders = require('internal.loaders')
local vshard = loaders.require_first('vshard-ee', 'vshard')
```
The function is for internal use.
It would be nice to have something of this kind in the public API, but
I'm not going to solve it within this patch.
Needed for tarantool/tarantool-ee#815
NO_DOC=no public API changes
NO_CHANGELOG=see NO_DOC
(cherry picked from commit 3abd4f9)
The new closed-source `vshard-ee` module was recently introduced. It is based on the open-source `vshard` module and, as far as I know, provides the same API. Let's configure `vshard-ee` in the same way as `vshard` if sharding is enabled in tarantool's configuration. Prefer `vshard-ee` if both are available. Fixes tarantool/tarantool-ee#815 @TarantoolBot document Title: config: vshard-ee is now supported The declarative configuration supports `vshard-ee` in addition to `vshard` since Tarantool 3.1.1 and 3.2+. `vshard` is mentioned in the documentation at least [here][1]. All such places should be updated to mention both `vshard-ee` and `vshard`. [1]: https://www.tarantool.io/en/doc/latest/reference/configuration/configuration_reference/#sharding (cherry picked from commit 29519c7)
|
The reviews are done in PR #10129. This is a backport of the same patches without any changes. I'll proceed with them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This is a backport of PR #10129 to
release/3.1, future3.1.1release.)The new closed-source
vshard-eemodule was recently introduced. It is based on the open-sourcevshardmodule and, as far as I know, provides the same API.Let's configure
vshard-eein the same way asvshardif sharding is enabled in tarantool's configuration.Prefer
vshard-eeif both are available.Fixes https://github.com/tarantool/tarantool-ee/issues/815