box: add stub function to register extra security methods #8055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After checking that the received authentication method and type are compatible with auth_request_check(), authenticate() tries to authenticate it using the user's authentication method with authenticate_request(). The problem is the user may use a different authenticate method from the one received in the request while authenticate_request() expects the request to be valid. As a result, it may crash in this case. Fix this by ensuring that the user's authentication method matches the one received in the request. Follow-up commit b5754d3 ("box: make auth subsystem pluggable") Follow-up tarantool#7986 NO_DOC=bug fix NO_CHANGELOG=unreleased NO_TEST=will be added to EE, because CE supports just one auth method
locker
force-pushed
the
auth-methods-ee-stub
branch
from
c80023c
to
4185c69
Compare
alyapunov
approved these changes
Dec 13, 2022
This commit adds function stubs security_init and security_free that are called after auth_init and before auth_free, respectively. We'll define them in the EE repository along with the enabling macros: ENABLE_SECURITY and SECURITY_SOURCES. We'll start with adding extra authentication methods in security_init. Later on, we'll implement more security features, like password strength enforcement or authentication delay. Needed for tarantool/tarantool-ee#295 NO_DOC=internal NO_TEST=internal NO_CHANGELOG=internal
locker
force-pushed
the
auth-methods-ee-stub
branch
from
4185c69
to
39723e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a stub function that will add extra authentication methods in Tarantool Enterprise Edition. Also, it fixes a bug in
authenticate()that can result in a crash if there's more than one authentication method available.Needed for https://github.com/tarantool/tarantool-ee/issues/295
Follow-up #7986