replication: allow to pass instance name as bootstrap_leader #8729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreyaksenov
approved these changes
Jun 1, 2023
| @@ -0,0 +1,15 @@ | |||
| ## feature/replication | |||
|
|
|||
| * Added ability to set `bootstrap_leader` configuration option to the instance | |||
There was a problem hiding this comment.
Suggested change
| * Added ability to set `bootstrap_leader` configuration option to the instance | |
| * Added the ability to set the `bootstrap_leader` configuration option to the instance |
There was a problem hiding this comment.
Thanks! Fixed.
sergepetrenko
force-pushed
the
gh-8539-bootstrap-leader-name
branch
3 times, most recently
from
e8185e7
to
e0e247f
Compare
sergepetrenko
force-pushed
the
gh-8539-bootstrap-leader-name
branch
2 times, most recently
from
8d19685
to
6a878e7
Compare
grafin
requested changes
Jun 2, 2023
sergepetrenko
force-pushed
the
gh-8539-bootstrap-leader-name
branch
from
6a878e7
to
d7986d8
Compare
grafin
approved these changes
Jun 6, 2023
Node's ballot contains all the information necessary to choose it a bootstrap leader. Since the bootstrap_leader configuration option will allow specifying bootstrap leader's name, we have to broadcast the name in node's ballot. Prerequisite tarantool#8539 NO_CHANGELOG=not user-visible @TarantoolBot document Title: new field in node's BALLOT: IPROTO_BALLOT_INSTANCE_NAME The node's ballot (IPROTO_BALLOT) receives a new field: the name of the node (the same as in box.cfg.instance_name or box.info.name): Key: IPROTO_BALLOT_INSTANCE_NAME = 0x0a Value: MP_STR, representing the instance name.
Make it possible to specify the bootstrap leader via an instance name in addition to its URI and UUID. While I'm at it, change the argument order of box_check_node_name() to comply with box_check_uuid/uri/uri_set(). Closes tarantool#8539 @TarantoolBot document Title: `box.cfg.bootstrap_leader` accepts instance names now The option `box.cfg.bootstrap_leader`, which specifies the desired bootstrap leader when bootstrap_strategy is "config" now accepts instance names. For example, this is a valid config without replication: ```lua box.cfg{ instance_name = 'main-server', bootstrap_strategy = 'config', bootstrap_leader = 'main-server' } ``` When `box.cfg` contains some entries in `replication`, the node will bootstrap from the node which has the instance name specified in `box.cfg.bootstrap_leader`. This is an addition to tarantool/doc#3432
sergepetrenko
force-pushed
the
gh-8539-bootstrap-leader-name
branch
from
d7986d8
to
6ffac11
Compare
Gerold103
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it possible to specify the bootstrap leader via an instance name in addition to its URI and UUID.
Closes #8539
@TarantoolBot document
Title:
box.cfg.bootstrap_leaderaccepts instance names nowThe option
box.cfg.bootstrap_leader, which specifies the desired bootstrap leader when bootstrap_strategy is "config" now accepts instance names.For example, this is a valid config without replication:
When
box.cfgcontains some entries inreplication, the node will bootstrap from whatever node which has itsbox.cfg.instance_nameset to the same value as specified inbox.cfg.bootstrap_leader.This is an addition to tarantool/doc#3432