Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

box: fix memory leaks on ER_MULTISTATEMENT_TRANSACTION in DDL #8795

Merged
merged 1 commit into from Jun 23, 2023
Merged

box: fix memory leaks on ER_MULTISTATEMENT_TRANSACTION in DDL #8795

merged 1 commit into from Jun 23, 2023

Conversation

CuriousGeorgiy
Copy link
Member

@CuriousGeorgiy CuriousGeorgiy commented Jun 21, 2023 •
edited

Closes #8773

@CuriousGeorgiy CuriousGeorgiy requested a review from a team as a code owner June 21, 2023 14:04
@coveralls
Copy link

coveralls commented Jun 21, 2023 •
edited

Coverage Status

coverage: 85.923% (+0.006%) from 85.917% when pulling 9bd6352 on CuriousGeorgiy:gh-8773-ddl-leaks into d63a4bf
on tarantool:master.

locker
locker reviewed Jun 23, 2023
View reviewed changes
test/box-luatest/gh_8733_ddl_memory_leaks_test.lua Outdated Show resolved Hide resolved
src/box/memtx_space.c Outdated Show resolved Hide resolved
@locker locker assigned CuriousGeorgiy and unassigned locker Jun 23, 2023
@CuriousGeorgiy CuriousGeorgiy force-pushed the gh-8773-ddl-leaks branch 2 times, most recently from 755bd28 to d450f7f Compare June 23, 2023 10:13
@locker
Copy link
Member

locker commented Jun 23, 2023

Wrong ticket. Please fix.

@locker locker assigned CuriousGeorgiy and unassigned locker Jun 23, 2023
@CuriousGeorgiy
box: fix memory leaks on ER_MULTISTATEMENT_TRANSACTION in DDL
9bd6352 
Space index build and space format checking operations don't destroy space
iterator on `txn_check_singlestatement` failure — fix this.

Closes tarantool#8773

NO_DOC=bugfix
NO_TEST=<leak happens in small, cannot be detected by sanitizer>
@CuriousGeorgiy
Copy link
Member Author

@locker fixed ticket number.

@CuriousGeorgiy CuriousGeorgiy added the full-ci Enables all tests for a pull request label Jun 23, 2023
@locker locker merged commit 6689f51 into tarantool:master Jun 23, 2023
141 checks passed
@locker
Copy link
Member

locker commented Jun 23, 2023

Cherry-picked to 2.11 and 2.10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@locker locker locker approved these changes

@andreyaksenov andreyaksenov andreyaksenov approved these changes

Assignees

@locker locker

Labels
full-ci Enables all tests for a pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Memory leaks in memtx_space_build_index and memtx_space_check_format functions.
4 participants
@CuriousGeorgiy @coveralls @locker @andreyaksenov