test: fix for gh_6128 test to avoid flakiness #8823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ligurio
approved these changes
Jun 29, 2023
ligurio
force-pushed
the
Lord-KA/gh-6128-fix-flaky-test
branch
4 times, most recently
from
349cc45
to
4fd95ea
Compare
Test runs an external process with tarantool that writes to a log file. Then test reads that log file and searches a string with required message in it (see function check_err_msg). Test was flaky on macOS and I suspect it was happening due to a high log level - timeout was not enough to wait message in the log file. Patch decreases a log level to a default value and replaces io functions with the similar alternatives in a fio module. Using fio functions allows to not block fibers. NO_CHANGELOG=test fix NO_DOC=test fix
Lord-KA
force-pushed
the
Lord-KA/gh-6128-fix-flaky-test
branch
from
4fd95ea
to
9ea1243
Compare
|
@ligurio, thanks for the alternative fix! Your solution solves the underneath problem, so lets stick with it. I can't set a gh approve because this is my PR, but anyway LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #6128
NO_DOC=test fix
NO_CHANGELOG=test fix