lua/fiber: do not raise on printing a dead fiber #9099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p7nov
reviewed
Sep 7, 2023
changelogs/unreleased/gh-4265-printing-a-finished-fiber-stops-the-program.md
Outdated
Show resolved
Hide resolved
p7nov
approved these changes
Sep 7, 2023
ochaplashkin
approved these changes
Sep 7, 2023
locker
requested changes
Sep 7, 2023
Gumix
force-pushed
the
iverbin/gh-4265-printing-a-finished-fiber-stops-the-program
branch
from
793c9e4
to
715cb93
Compare
An attempt to print a dead fiber raised a fatal error, which is quite unexpected. This patch updates __tostring metamethod of fiber_object so that it pushes the "fiber: <fid> (dead)" string instead of the error. The __serialize metamethod is patched similarly. Closes tarantool#4265 NO_DOC=bugfix
Gumix
force-pushed
the
iverbin/gh-4265-printing-a-finished-fiber-stops-the-program
branch
from
715cb93
to
6a93581
Compare
locker
approved these changes
Sep 7, 2023
|
Cherry-picked to 2.11. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt to print a dead fiber raised a fatal error, which is quite unexpected.
This patch updates
__tostringmetamethod offiber_objectso that it pushes thefiber: <fid> (dead)string instead of the error. The__serializemetamethod is patched similarly.Closes #4265