box: fix out of bound write in error_payload_destroy()
#9114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p7nov
approved these changes
Sep 8, 2023
locker
requested changes
Sep 8, 2023
changelogs/unreleased/gh-9098-out-of-bound-write-in-error_payload_destroy.md
Outdated
Show resolved
Hide resolved
ochaplashkin
approved these changes
Sep 8, 2023
If `strlen(name)` is 1, `value_size` is 1, and `extra` is 0, then 15 bytes are allocated for `struct error_field` in error_payload_prepare(). However, the size of this structure is 16 because of the padding for the alignment. Thus TRASH() in error_payload_destroy() writes 1 byte beyond the structure. Closes tarantool#9098 NO_DOC=bugfix
Gumix
force-pushed
the
iverbin/gh-9098-heap-buffer-overflow-in-xrow_decode_error
branch
from
d927d3a
to
077d23d
Compare
Gumix
commented
Sep 8, 2023
locker
approved these changes
Sep 11, 2023
|
Cherry-picked to 2.11. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
strlen(name)is 1,value_sizeis 1, andextrais 0, then 15 bytes are allocated forstruct error_fieldinerror_payload_prepare(). However, the size of this structure is 16 because of the padding for the alignment. ThusTRASH()inerror_payload_destroy()writes 1 byte beyond the structure.Closes #9098