log: make log.cfg{modules=...} work as box.cfg{log_modules=...}
#9290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Configuring log modules work differently with log.cfg and box.cfg:
box.cfg{log_modules=...} overwrites the current config completely while
log.cfg{modules=...} overwrites the currently config only for the
specified modules. Let's fix this inconsistency by making log.cfg behave
exactly as box.cfg.
Closes tarantool#7962
NO_DOC=bug fix
locker
force-pushed
the
gh-7962-log-cfg-modules-fix
branch
from
d2f1caf
to
8c2e5e1
Compare
nshy
approved these changes
Oct 23, 2023
p7nov
approved these changes
Oct 24, 2023
ylobankov
approved these changes
Oct 24, 2023
|
Cherry-picked to 2.11. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configuring log modules work differently with
log.cfgandbox.cfg:box.cfg{log_modules=...}overwrites the current config completely whilelog.cfg{modules=...}overwrites the currently config only for the specified modules. Let's fix this inconsistency by makinglog.cfgbehave exactly asbox.cfg.Closes #7962