config: fix hanging alert about missing name #9316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the last itaration of review it was decided to throw an alerts, when no UUID was passed to config and name is not set in _cluster. This leads to alerts, thrown during replicaset bootstrap. However, _cluster:on_replace trigger wasn't updated for that change, it asssumed that when insert of a new replica is done, no alerts was thrown. Let's fix the behavior of on_replace trigger so that it deletes alerts as soon as replica joined with name. Follow-up tarantool#8978 NO_DOC=bugfix NO_TEST=<already tested> NO_CHANGELOG=bugfix
Totktonada
approved these changes
Oct 27, 2023
ylobankov
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the last itaration of review it was decided to throw an alerts, when no UUID was passed to config and name is not set in _cluster.
This leads to alerts, thrown during replicaset bootstrap. However, _cluster:on_replace trigger wasn't updated for that change, it asssumed that when insert of a new replica is done, no alerts was thrown.
Let's fix the behavior of on_replace trigger so that it deletes alerts as soon as replica joined with name.
Follow-up #8978