Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: add dependencies for roles #9338

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

ImeevMA
Copy link
Collaborator

@ImeevMA ImeevMA commented Nov 7, 2023

This patch adds dependencies support for roles.

Part of #9078

@TarantoolBot document
Title: dependencies for roles

Roles can now have dependencies. This means that the verify() and apply() methods will be executed for these roles, taking into account the dependencies. Dependencies should be written in the "dependencies" field of the array type. Note, the roles will be loaded (not applied!) in the same order in which they were specified, i.e. not taking dependencies into account.

Example:

Dependencies of role A: B, C
Dependencies of role B: D
No other role has dependencies.

Order in which roles were given: [E, C, A, B, D, G]
They will be loaded in the same order: [E, C, A, B, D, G]
The order, in which functions verify() and apply() will be executed: [E, C, D, B, A, G].

@ImeevMA ImeevMA requested review from Totktonada and a team as code owners November 7, 2023 14:57
@ImeevMA ImeevMA force-pushed the imeevma/gh-9078-dependencies branch from 59fa815 to 79287dc Compare November 7, 2023 14:59
@coveralls
Copy link

coveralls commented Nov 7, 2023

Coverage Status

coverage: 86.667% (+0.005%) from 86.662%
when pulling 5815cdf on ImeevMA:imeevma/gh-9078-dependencies
into c92500a
on tarantool:master
.

changelogs/unreleased/gh-9078-role-dependencies.md Outdated Show resolved Hide resolved
src/box/lua/config/applier/roles.lua Show resolved Hide resolved
src/box/lua/config/applier/roles.lua Outdated Show resolved Hide resolved
test/config-luatest/roles_test.lua Outdated Show resolved Hide resolved
test/config-luatest/roles_test.lua Outdated Show resolved Hide resolved
@Totktonada Totktonada assigned ImeevMA and unassigned Totktonada Nov 13, 2023
@ImeevMA ImeevMA assigned Totktonada and unassigned ImeevMA Nov 23, 2023
@Totktonada Totktonada assigned ImeevMA and unassigned Totktonada Nov 26, 2023
This patch adds dependencies support for roles.

Part of tarantool#9078

@TarantoolBot document
Title: dependencies for roles

Roles can now have dependencies. This means that the verify() and
apply() methods will be executed for these roles, taking into account
the dependencies. Dependencies should be written in the "dependencies"
field of the array type. Note, the roles will be loaded (not applied!)
in the same order in which they were specified, i.e. not taking
dependencies into account.

Example:

Dependencies of role A: B, C
Dependencies of role B: D
No other role has dependencies.

Order in which roles were given: [E, C, A, B, D, G]
They will be loaded in the same order: [E, C, A, B, D, G]
The order, in which functions verify() and apply() will be executed:
[E, C, D, B, A, G].
@Totktonada Totktonada added the full-ci Enables all tests for a pull request label Nov 28, 2023
@Totktonada Totktonada merged commit 7fbc1d0 into tarantool:master Nov 29, 2023
106 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
full-ci Enables all tests for a pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants