Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport release/2.10] lua: prevent serialization of error for ucdata #9455

Conversation

Buristan
Copy link
Collaborator

@Buristan Buristan commented Dec 7, 2023

Without checking the return value of lua_pcall() in lua_field_inspect_ucdata(), the error message itself is returned as a serialized result. The result status of lua_pcall() is not ignored now.

NO_DOC=bugfix

Closes #9396

(cherry picked from commit 98474f7)

Since the behavior of the <app/fiber.lua> test is changed in 2.11 the result file is updated here.

Without checking the return value of `lua_pcall()` in
`lua_field_inspect_ucdata()`, the error message itself is returned as a
serialized result. The result status of `lua_pcall()` is not ignored
now.

NO_DOC=bugfix

Closes tarantool#9396

(cherry picked from commit 98474f7)

Since the behavior of the <app/fiber.lua> test is changed in 2.11 the
result file is updated here.
@Buristan Buristan added lua serializers Fearutes and bugs related to built-in serializers labels Dec 7, 2023
@Buristan Buristan force-pushed the skaplun/gh-9396-serialize-error-2.10 branch 2 times, most recently from e87ae92 to 66e5754 Compare December 7, 2023 09:08
@coveralls
Copy link

Coverage Status

coverage: 85.098% (-0.002%) from 85.1%
when pulling 66e5754 on Buristan:skaplun/gh-9396-serialize-error-2.10
into 1ef5626
on tarantool:release/2.10
.

@Buristan Buristan added the full-ci Enables all tests for a pull request label Dec 7, 2023
@Buristan Buristan marked this pull request as ready for review December 7, 2023 09:49
@Buristan Buristan requested review from a team as code owners December 7, 2023 09:49
Copy link
Collaborator

@igormunkin igormunkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Buristan, thanks for the patch! LGTM.

@igormunkin igormunkin removed the request for review from Lord-KA December 7, 2023 11:15
@igormunkin igormunkin merged commit 2487ab9 into tarantool:release/2.10 Dec 7, 2023
144 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
full-ci Enables all tests for a pull request lua serializers Fearutes and bugs related to built-in serializers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants