lyaml: fix alias serialization #9736
Closed
+1,439
−1,299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tarantool#8350 was introduced by the commit b42302f ("lua-yaml: enable aliasing for objects returned by __serialize") so the patch is effectively reversed. The idea is to call all object __serialize methods recursively before finding references. In the process we need to keep an eye on reference structure of course. Closes tarantool#8350 Closes tarantool#8321 Closes tarantool#8310 NO_DOC=bugfix
nshy
force-pushed
the
fix-serialization-anchors
branch
from
aa91fa1
to
b606dac
Compare
andreyaksenov
approved these changes
Feb 27, 2024
| @@ -0,0 +1,3 @@ | |||
| ## bugfix/lua | |||
|
|
|||
| * Fixed yaml alias serialization (gh-8350, gh-8321, gh-8310). | |||
There was a problem hiding this comment.
Suggested change
| * Fixed yaml alias serialization (gh-8350, gh-8321, gh-8310). | |
| * Fixed serialization of YAML aliases (gh-8350, gh-8321, gh-8310). |
ochaplashkin
approved these changes
Feb 28, 2024
Totktonada
previously approved these changes
Mar 1, 2024
|
@nshy asked me to send my proposal from this comment as a pull request. It is done in PR #9777. |
|
Closed as superseded by PR #9777 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The #8350 was introduced by the commit b42302f ("lua-yaml: enable aliasing for objects returned by __serialize") so the patch is effectively reversed.
The idea is to call all object
__serialize()methods recursively before finding references. In the process we need to keep an eye on reference structure of course.Closes #8350
Closes #8321
Closes #8310