space_upgrade: fix crashes on upgrading nullability #9907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewdzzz
force-pushed
the
space_upgrade_fix
branch
3 times, most recently
from
b961548
to
40ec462
Compare
drewdzzz
changed the title
drewdzzz
changed the title
drewdzzz
force-pushed
the
space_upgrade_fix
branch
2 times, most recently
from
f79bc3d
to
bc78576
Compare
sergepetrenko
approved these changes
Apr 11, 2024
drewdzzz
force-pushed
the
space_upgrade_fix
branch
2 times, most recently
from
7c9d9c2
to
85b381f
Compare
locker
requested changes
May 17, 2024
drewdzzz
force-pushed
the
space_upgrade_fix
branch
6 times, most recently
from
5cc8941
to
a8728e7
Compare
locker
reviewed
May 21, 2024
drewdzzz
force-pushed
the
space_upgrade_fix
branch
from
a8728e7
to
30ab873
Compare
When upgrading a space, attribute `has_optional_parts` of indexes can be changed. So in order to correctly index both old and new tuples we should set new min_field_count value to the minimal min_field_count of old and new formats. Actual value will be set when space upgrade completes. Part of tarantool/tarantool-ee#698 Part of tarantool/tarantool-ee#750 NO_TEST=in ee NO_CHANGELOG=in ee NO_DOC=bugfix
drewdzzz
force-pushed
the
space_upgrade_fix
branch
from
30ab873
to
1351c5d
Compare
locker
approved these changes
May 22, 2024
locker
added
full-ci
|
|
|
Cherry-picked to 2.11 and 3.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patch fixes crashes on upgrading nullability of trailing fields. If we had nullable one, and we upgrade it to non-nullable, attribute
has_optional_partof some indexes can be changed (even if no indexed fields are changed). So in order to correctly index both old and new tuples we should set new min_field_count value to the minimal min_field_count of old and new formats. Actual value will be set when space upgrade completes.This is CE part of the patch. It must be merged after EE part is approved and all tests there are passed.
EE part: tarantool/tarantool-ee#748
Part of tarantool/tarantool-ee#698
Part of tarantool/tarantool-ee#750