lua: set error trace to the caller place

[nshy]

Currently trace points to the C code where diag is set or Lua code where error is thrown. So it points to internal code which is not particularly useful for the user. Let's make trace point the place where API is called. This patch do it for API residing in several modules only though (schema.lua is one of them).

Closes #9914

DO NOT MERGE Depends on PR tarantool/test-run#428

See EE PR https://github.com/tarantool/tarantool-ee/pull/791

[coveralls]

coverage: 87.091% (-0.03%) from 87.125%
when pulling cca9139 on nshy:error-add-lua-trace
into 1f75231
on tarantool:master.

[locker]

Looked through patches 1-3.

[nshy]

Moved the last patch to the first place (as it fixes build error on my development environment).

[Totktonada]

OK regarding the test/config-luatest changes.

[nshy]

Restored the original usage of return <raise_some_lua_error>() and unreachable() to fix clang compiler warnings.

diff

diff --git a/src/box/lua/error.cc b/src/box/lua/error.cc
index 5a60a9d5a..2710dcc44 100644
--- a/src/box/lua/error.cc
+++ b/src/box/lua/error.cc
@@ -335,7 +335,7 @@ luaT_error_new(lua_State *L)
 	struct error *e = luaT_error_create(L, 1);
 	if (e == NULL) {
 		diag_set(IllegalParams, "box.error.new(): bad arguments");
-		luaT_error(L);
+		return luaT_error(L);
 	}
 	lua_settop(L, 0);
 	luaT_pusherror(L, e);
@@ -359,7 +359,7 @@ luaT_error_set(struct lua_State *L)
 {
 	if (lua_gettop(L) == 0) {
 		diag_set(IllegalParams, "Usage: box.error.set(error)");
-		luaT_error(L);
+		return luaT_error(L);
 	}
 	struct error *e = luaT_checkerror(L, 1);
 	diag_set_error(&fiber()->diag, e);
diff --git a/src/box/lua/init.c b/src/box/lua/init.c
index efcef24ee..307ba9dd7 100644
--- a/src/box/lua/init.c
+++ b/src/box/lua/init.c
@@ -758,7 +758,7 @@ lbox_backup_start(struct lua_State *L)
 		checkpoint_idx = luaT_checkint(L, 1);
 		if (checkpoint_idx < 0) {
 			diag_set(IllegalParams, "invalid checkpoint index");
-			luaT_error(L);
+			return luaT_error(L);
 		}
 	}
 	lua_newtable(L);
diff --git a/src/lua/fiber.c b/src/lua/fiber.c
index 5821cab59..82a6fa9a9 100644
--- a/src/lua/fiber.c
+++ b/src/lua/fiber.c
@@ -945,6 +945,7 @@ lbox_fiber_slice_parse(struct lua_State *L, int idx)
 			 "slice must be a number or a table "
 			 "{warn = <number>, err = <number>}");
 		luaT_error(L);
+		unreachable();
 	}
 	if (!fiber_slice_is_valid(slice)) {
 		diag_set(IllegalParams, "slice value must be >= 0");
diff --git a/src/lua/init.c b/src/lua/init.c
index 9efc233be..c6787d39d 100644
--- a/src/lua/init.c
+++ b/src/lua/init.c
@@ -394,7 +394,7 @@ lbox_tonumber64(struct lua_State *L)
 		base = (base == -1 ? 10 : base);
 		if (base != 10) {
 			diag_set(IllegalParams, "argument 1 is not a string");
-			luaT_error(L);
+			return luaT_error(L);
 		}
 		lua_settop(L, 1); /* return original value as is */
 		return 1;
@@ -488,7 +488,7 @@ skip:		base = (base == -1 ? 10 : base);
 		base = (base == -1 ? 10 : base);
 		if (base != 10) {
 			diag_set(IllegalParams, "argument 1 is not a string");
-			luaT_error(L);
+			return luaT_error(L);
 		}
 		uint32_t ctypeid = 0;
 		luaL_checkcdata(L, 1, &ctypeid);

</details>

[nshy]

One of the integration test does not expect empty error trace (file is "" and line is 0) fox netbox eval. Fixed to keep existing error trace on luaL_loadbuffer() failure in `execute_lua_eval()

Also added a test for error trace on code evaluation and function call over netbox as suggested by @locker.

diff

diff --git a/src/box/lua/call.c b/src/box/lua/call.c
index 51ce67997..5267e8777 100644
--- a/src/box/lua/call.c
+++ b/src/box/lua/call.c
@@ -447,7 +447,7 @@ execute_lua_eval(lua_State *L)
        uint32_t expr_len = ctx->name_len;
        if (luaL_loadbuffer(L, expr, expr_len, "=eval")) {
                diag_set(LuajitError, lua_tostring(L, -1));
-               luaT_error(L);
+               luaT_error_at(L, 0);
        }

        /* Unpack arguments */
diff --git a/test/box-luatest/error_subsystem_improvements_test.lua b/test/box-luatest/error_subsystem_improvements_test.lua
index 5379cd426..a81c25d4f 100644
--- a/test/box-luatest/error_subsystem_improvements_test.lua
+++ b/test/box-luatest/error_subsystem_improvements_test.lua
@@ -1051,6 +1051,40 @@ g.test_illegal_params = function()
     t.assert_equals(e.message, 'foo')
 end
 
+g.test_netbox_call_trace = function(cg)
+    local netbox = require('net.box')
+    local file = debug.getinfo(1, 'S').short_src
+    local line = debug.getinfo(1, 'l').currentline + 4
+    cg.server:exec(function()
+        box.schema.create_space('test')
+        rawset(_G, 'test_func', function()
+            box.space.test:insert({})
+        end)
+    end)
+
+    local function test_error(file, line, fn, ...)
+        local ok, err = pcall(fn, ...)
+        t.assert_not(ok)
+        t.assert(box.error.is(err))
+        t.assert_equals(err.message, "No index #0 is defined in space 'test'")
+        local trace = err.trace[1]
+        t.assert_equals(trace.line, line)
+        t.assert_equals(trace.file, file)
+    end
+
+    local c = netbox.connect(cg.server.net_box_uri)
+    test_error('eval', 3, c.eval, c, '\n\nbox.space.test:insert({})')
+    test_error(file, line, c.call, c, 'test_func')
+end
+
+g.after_test('test_netbox_call_trace', function(cg)
+    cg.server:exec(function()
+        if box.space.test ~= nil then
+            box.space.test:drop()
+        end
+    end)
+end)
+
 g.test_trace_checked = function()
    local st, res = pcall(t.assert_error,
                          tarantool._internal.raise_incorrect_trace)