adding defaults for chef_omnibus_root for windows and unix-like/linux…

… systems

This work patches test-kitchen#923 so that the issue will stop bugging people, and we can discuss implementing mixlib-install but that has downstream affects against cinc.

lib/kitchen/provisioner/chef_base.rb

@@ -44,6 +44,7 @@ module Provisioner
     class ChefBase < Base
       default_config :require_chef_omnibus, true
       default_config :chef_omnibus_url, "https://omnitruck.chef.io/install.sh"
+      default_config :chef_omnibus_root,"/opt/chef"
       default_config :chef_omnibus_install_options, nil
       default_config :chef_license, nil
       default_config :run_list, []
@@ -341,6 +342,7 @@ def last_exit_code
       # @api private
       def install_options
         add_omnibus_directory_option if instance.driver.cache_directory
+        chef_omnibus_root
         project = /\s*-P (\w+)\s*/.match(config[:chef_omnibus_install_options])
         {
           omnibus_url: config[:chef_omnibus_url],
@@ -552,6 +554,12 @@ def omnibus_dir_option
         windows_os? ? "-download_directory" : "-d"
       end
 
+      # @return [String] Correct config when running in Windows,
+      # @api private
+      def omnibus_root_dir
+        config[:chef_omnibus_root] = windows_os? ? "C:\opscode" : config[:chef_omnibus_root]
+      end
+
       def install_from_file(command)
         install_file = "/tmp/chef-installer.sh"
         script = ["cat > #{install_file} <<\"EOL\""]

spec/kitchen/provisioner/chef_base_spec.rb

@@ -61,6 +61,11 @@ def calculate_path(path, _opts = {})
           .must_equal "https://omnitruck.chef.io/install.sh"
       end
 
+      it ":chef_omnibus_root has a default" do
+        provisioner[:chef_omnibus_root]
+            .must_equal "/opt/chef"
+      end
+
       it ":chef_metadata_url defaults to nil" do
         provisioner[:chef_metadata_url].must_be_nil
       end
@@ -73,6 +78,11 @@ def calculate_path(path, _opts = {})
         provisioner[:chef_omnibus_url]
           .must_equal "https://omnitruck.chef.io/install.sh"
       end
+
+      it ":chef_omnibus_root has a default" do
+        provisioner[:chef_omnibus_root]
+            .must_equal "C:\opscode"
+      end
     end
 
     it ":require_chef_omnibus defaults to true" do