New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added interaction type in rpacket_tracker #2091
Added interaction type in rpacket_tracker #2091
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Co-authored-by: Wolfgang Kerzendorf <wkerzendorf@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #2091 +/- ##
==========================================
- Coverage 61.46% 61.41% -0.05%
==========================================
Files 75 75
Lines 8620 8626 +6
==========================================
Hits 5298 5298
- Misses 3322 3328 +6
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
…rdis-sn#2052) * Added functions to store and load a runner object * Updated hardcode file name in runner_from_hdf * Updated store_runner_to_hdf to append to file * Added name and email to .mailmap * runner hdf functions convert to cgs * store_runner_to_hdf clears group before storing * Storing units for astropy quantities * Formatted code with black * Added functions to store and load model objects * Fixed typo and decoded string from bytes * Fixed typo * Added test for model_to_dict * Formatted previous test code * Added test for store_model_to_hdf * Fixed formatting of model_to_hdf * Fixed issue with test for model_to_dict * Added test for runner_to_dict * Fixed issue with single packet seed storage * Updated test null value of single packet seed * Added test for store_runner_to_hdf * Updated to use isinstance and hasattr * runner_to_dict returns dicts instead of iterators * Reordered imports to match pep8 style
* Remove yaml_load_config_file * updated mailmap * Updated __init__.py
…sn#2076) Fix function name according pep8
* Moved the trace_packet function to the transport module, renamed the function to remove continuum reference as it is generic * Formatted to PEP 8 * Reformatted single_packet_loop for PEP 8 * removed old continuum trace packet files * removed references to old files * Added some docstrings * Missed an old function call
* creating files and sections * adding images * writing intro to tardis physics and adding it to sidebar * changing spectra page structure * mostly complete draft of light and matter page * spectrum page * fixing up physics stuff * fixing docstring * Revert "fixing docstring" This reverts commit e24cadd. * andrew's changes * a few more edits * adding note about angstroms
* Removed line profile as option * Removed mapping to Cartesian grid * Removed automatic plotting after profile creation * Fixed typo in arepo plot * Updated documentation * [build docs] * [build docs] Removed outputs from doc-notebook * Updated tests with new models * Removed deprecated keyword in snapshot loader * Replaced wget with requests for testfile download * Updated file retrieval for testing * Fixed fixture request * Added arepo data to refdata helper * Updated refdata location in docs * Updated paths in tests * Update download_reference_data.sh * Testing areop_parser_tests * Fixed deleted reference file
* [build-docs] Fixed link in arepo docs * [build-docs] Changed filename in arepo docs * [build-docs] * [build-docs] * [build-docs] * [build docs] * [build-docs] Changed refdata url * [build_docs] * Updated mailmap * [build_docs] Updated url for refdata download
* creating new docs building instructions * typos, grammar, and text in hyperlinks
…dis into rpacket-interaction-add
*beep* *bop* Hi, human. The Click here to see your results. |
📝 Description
rpacket_tracker would return a new attribute 'interaction type' which contains the type of interaction a packet undergoes.
For visual demo visit #2057
Type: 🚀
feature
Write a complete description of your changes, including the necessary context or any piece of information required to understand your work.
Also, link issues affected by this pull request by using the keywords:
close
,closes
,closed
,fix
,fixes
,fixed
,resolve
,resolves
orresolved
.📌 Resources
Examples, notebooks, and links to useful references.
🚦 Testing
How did you test these changes?
☑️ Checklist
build_docs
label