Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating new docs building instructions #2097

Merged
merged 2 commits into from Jul 18, 2022

Conversation

isaacgsmith
Copy link
Member

@isaacgsmith isaacgsmith commented Jul 18, 2022

馃摑 Description

Type: 馃摑 documentation

Adds updated instructions for building documentation on GitHub.

Closes #2089.

馃搶 Resources

See the docs: https://tardis-sn.github.io/tardis/pull/2097/contributing/development/documentation_guidelines.html

馃殾 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

Docs built on GitHub.

鈽戯笍 Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

@codecov
Copy link

codecov bot commented Jul 18, 2022

Codecov Report

Merging #2097 (c640bf3) into master (a2ed8b5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2097   +/-   ##
=======================================
  Coverage   58.13%   58.13%           
=======================================
  Files          75       75           
  Lines        8602     8602           
=======================================
  Hits         5001     5001           
  Misses       3601     3601           

馃摚 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@isaacgsmith isaacgsmith changed the title creating new docs building instructions Creating new docs building instructions Jul 18, 2022
@isaacgsmith isaacgsmith marked this pull request as draft July 18, 2022 04:30
@tardis-bot
Copy link
Contributor

*beep* *bop*

Hi, human.

The docs workflow has succeeded 鉁旓笍

Click here to see your results.

@isaacgsmith isaacgsmith marked this pull request as ready for review July 18, 2022 11:52
Copy link
Member

@jaladh-singhal jaladh-singhal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect @smithis7! I was also confused/ignorant about how to build docs with new workflow

@andrewfullard andrewfullard merged commit 6269996 into tardis-sn:master Jul 18, 2022
@isaacgsmith isaacgsmith deleted the build_docs_instructions branch July 19, 2022 20:27
jayantbhakar pushed a commit to jayantbhakar/tardis that referenced this pull request Jul 29, 2022
* creating new docs building instructions

* typos, grammar, and text in hyperlinks
andrewfullard pushed a commit that referenced this pull request Aug 3, 2022
* rpacket_tracker returns dataframe

* added black formatting

* replaced variable i

* added rpacket_tracker_df as separate variable

* added preallocation step

* added non-preallocated-df generator function

* tests for df generator function

* renamed variables

* assert statements corrected

* added seed column in df

* added documentation for rpacket_tracker_df

* added doc str

* initial commit

* updated documention

* moved function to r_packet.py

* added block indexing to df

Co-authored-by: Wolfgang Kerzendorf <wkerzendorf@gmail.com>

* updated the df function

* added multiindexing

* shifted the df function call

* initial commit

* interaction type added

* removed unused imports

* added tests

* initial commit

* interaction type added

* Created a smart HDF Reader which can re-produce simulation object (#2052)

* Added functions to store and load a runner object

* Updated hardcode file name in runner_from_hdf

* Updated store_runner_to_hdf to append to file

* Added name and email to .mailmap

* runner hdf functions convert to cgs

* store_runner_to_hdf clears group before storing

* Storing units for astropy quantities

* Formatted code with black

* Added functions to store and load model objects

* Fixed typo and decoded string from bytes

* Fixed typo

* Added test for model_to_dict

* Formatted previous test code

* Added test for store_model_to_hdf

* Fixed formatting of model_to_hdf

* Fixed issue with test for model_to_dict

* Added test for runner_to_dict

* Fixed issue with single packet seed storage

* Updated test null value of single packet seed

* Added test for store_runner_to_hdf

* Updated to use isinstance and hasattr

* runner_to_dict returns dicts instead of iterators

* Reordered imports to match pep8 style

* Remove yaml_load_config_file (#2062)

* Remove yaml_load_config_file

* updated mailmap

* Updated __init__.py

* Modified Function Name in Config validator according to PEP8 (#2076)

Fix function name according pep8

* Added documetation on how to compare environment before update (#2082)

* Moved `trace_packet` to tardis tansport (#2083)

* Moved the trace_packet function to the transport module, renamed the function to remove continuum reference as it is generic

* Formatted to PEP 8

* Reformatted single_packet_loop for PEP 8

* removed old continuum trace packet files

* removed references to old files

* Added some docstrings

* Missed an old function call

* Fix broken links in workflow files and goverance md (#2084)

* Adding physics introduction to documentation (#2026)

* creating files and sections

* adding images

* writing intro to tardis physics and adding it to sidebar

* changing spectra page structure

* mostly complete draft of light and matter page

* spectrum page

* fixing up physics stuff

* fixing docstring

* Revert "fixing docstring"

This reverts commit e24cadd.

* andrew's changes

* a few more edits

* adding note about angstroms

* Improved arepo parser (#1941)

* Removed line profile as option

* Removed mapping to Cartesian grid

* Removed automatic plotting after profile creation

* Fixed typo in arepo plot

* Updated documentation

* [build docs]

* [build docs] Removed outputs from doc-notebook

* Updated tests with new models

* Removed deprecated keyword in snapshot loader

* Replaced wget with requests for testfile download

* Updated file retrieval for testing

* Fixed fixture request

* Added arepo data to refdata helper

* Updated refdata location in docs

* Updated paths in tests

* Update download_reference_data.sh

* Testing areop_parser_tests

* Fixed deleted reference file

* Arepo docs fix (#2088)

* [build-docs] Fixed link in arepo docs

* [build-docs] Changed filename in arepo docs

* [build-docs]

* [build-docs]

* [build-docs]

* [build docs]

* [build-docs] Changed refdata url

* [build_docs]

* Updated mailmap

* [build_docs] Updated url for refdata download

* Creating new docs building instructions (#2097)

* creating new docs building instructions

* typos, grammar, and text in hyperlinks

* added tests

* added documentation, black formatting

Co-authored-by: Wolfgang Kerzendorf <wkerzendorf@gmail.com>
Co-authored-by: Satwik Kambham <satwik.kambham@gmail.com>
Co-authored-by: aman kumar <ak584584@gmail.com>
Co-authored-by: Rohith Varma Buddaraju <rohith.varma.buddaraju@gmail.com>
Co-authored-by: Jaladh Singhal <jaladhsinghal@gmail.com>
Co-authored-by: Jack O'Brien <jobrien585@gmail.com>
Co-authored-by: Isaac Smith <71480393+smithis7@users.noreply.github.com>
Co-authored-by: AlexHls <70367168+AlexHls@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation on buiding docs is outdated
5 participants