Fix bug in plasma #743
Merged
Fix bug in plasma #743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chvogl
approved these changes
Jun 14, 2017
| """ | ||
| Reduces non-metastable level populations by a factor of W compared to LTE in the case of dilute-lte excitation. | ||
| Reduces non-metastable level populations by a factor of W |
There was a problem hiding this comment.
This is not what this method does.
| """ | ||
| outputs = ('level_number_density',) | ||
| latex_name = ('N_{i,j,k}',) | ||
| latex_formula = ('N_{i,j}\\dfrac{bf_{i,j,k}}{Z_{i,j}}',) | ||
|
|
||
| def calculate(self): | ||
| pass | ||
|
|
||
| def __init__(self, plasma_parent): | ||
| """ | ||
| Calculates the level populations with the Boltzmann equation in LTE. |
There was a problem hiding this comment.
I know that this is not particularly relevant for this PR but this class has nothing to do with either the Boltzmann equation or LTE. It is used for all excitation treatments including dilute-lte and nlte.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While having a second look at the LevelNumberDensity module in plasma I found a bug.
Instead of defining the
calculatefunction as a method, we assigned an attribute with a reference to a method during the__init__. That is a so calledinstancemethodand should only be used in special cases. In our case thecalculatemethod is the same for all instances which should be reflected by the class.If this fix hides implementation details, one could leave the original names and assign the function on the class level instead of in the
__init__.