Support extra variables (#104)

* substitute env variables in the bot name and output rooms
* added logging

Makefile

@@ -2,4 +2,4 @@ build:
 	go build -v -a -o flottbot cmd/flottbot/main.go
 
 run: build
-	./flottbot
+	./flottbot

core/configure.go

@@ -41,6 +41,14 @@ func initLogger(b *models.Bot) {
 // configureChatApplication configures a user's specified chat application
 // TODO: Refactor to keep remote specifics in remote/
 func configureChatApplication(bot *models.Bot) {
+
+	// update the bot name
+	token, err := utils.Substitute(bot.Name, map[string]string{})
+	if err != nil {
+		bot.Log.Warnf("Could not configure bot Name: %s", err.Error())
+	}
+	bot.Name = token
+
 	if bot.ChatApplication != "" {
 		switch strings.ToLower(bot.ChatApplication) {
 		case "discord":

core/configure_test.go

@@ -268,21 +268,31 @@ func Test_validateRemoteSetup(t *testing.T) {
 }
 
 func TestConfigure(t *testing.T) {
+
 	testBot := new(models.Bot)
+	testBot.Name = "mybot(${FB_ENV})"
 	testBot.CLI = true
 
+	os.Setenv("FB_ENV", "dev")
+	defer os.Unsetenv("FB_ENV")
+
 	type args struct {
 		bot *models.Bot
 	}
 	tests := []struct {
-		name string
-		args args
+		name   string
+		args   args
+		expect args
 	}{
-		{"Basic", args{bot: testBot}},
+		{"Basic", args{bot: testBot}, args{bot: &models.Bot{Name: "mybot(dev)"}}},
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
 			Configure(tt.args.bot)
+
+			if tt.args.bot.Name != tt.expect.bot.Name {
+				t.Errorf("configure() wanted bot.Name set to %v, but got %v", tt.args.bot.Name, tt.expect.bot.Name)
+			}
 		})
 	}
 }

core/rules.go

@@ -1,6 +1,7 @@
 package core
 
 import (
+	"fmt"
 	"os"
 	"path"
 	"path/filepath"
@@ -59,8 +60,26 @@ func Rules(rules *map[string]models.Rule, bot *models.Bot) {
 		if err != nil {
 			log.Fatalf(err.Error())
 		}
+		err = validateRule(bot, &rule)
+		if err != nil {
+			log.Fatalf(err.Error())
+		}
 		(*rules)[ruleFile] = rule
 	}
 
 	bot.Log.Infof("Configured '%s' rules!", bot.Name)
 }
+
+// Validate applies any environmental changes
+func validateRule(bot *models.Bot, r *models.Rule) error {
+
+	for i := range r.OutputToRooms {
+		token, err := utils.Substitute(r.OutputToRooms[i], map[string]string{})
+		if err != nil {
+			return fmt.Errorf("Could not configure output room: %s", err.Error())
+		}
+
+		r.OutputToRooms[i] = token
+	}
+	return nil
+}