Support extra variables

[sarge]

❤ THANKS FOR HELPING OUT :D

Proposed change

Addresses adding environment variables #101

Types of changes

What types of changes is this pull request introducing to flottbot? Put an x in the boxes that apply

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

You can fill this out after creating your PR. Put an x in the boxes that apply

• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)

[coveralls]

Pull Request Test Coverage Report for Build 214

• 6 of 21 (28.57%) changed or added relevant lines in 2 files are covered.
• 1 unchanged line in 1 file lost coverage.
• Overall coverage decreased (-0.1%) to 39.444%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
core/configure.go	6	8	75.0%
core/rules.go	0	13	0.0%

Files with Coverage Reduction	New Missed Lines	%
core/rules.go	1	0.0%

Totals
Change from base Build 213:	-0.1%
Covered Lines:	781
Relevant Lines:	1980

---

💛 - Coveralls

[sarge]

@JordanSussman this is what I did to support additional variables in the configuration phase.
I would have put validate on the Rule model but needed access to the utils.Substitute in another package.

[JordanSussman]

Hey @sarge, sorry for the late review of this! Been a bit hectic with moving and being on-call the following week.

I'm digging through a number of other repos and pull requests but I'll try and take a look at this in the next day or so.

[JordanSussman]

@wass3r @sjqnn @pa3ng - can one of you take a look at this too?

[wass3r]

Yea, I think this is fine. Would be good to add to docs to explain which configuration items allow env var substitution. Thanks @sarge !