Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ks musig presentation #124

Merged
merged 36 commits into from Feb 15, 2019
Merged

Ks musig presentation #124

merged 36 commits into from Feb 15, 2019

Conversation

Kevoulee
Copy link
Contributor

No description provided.

Copy link
Contributor

@hansieodendaal hansieodendaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks @Kevoulee

@@ -342,9 +342,9 @@ $$

#### Round 2

The signer generates a random $ r_{1}\leftarrow\mathbb{Z_{\mathrm{p}}} $, computes $ R_{1} = g^{r_{1}} $ and $ t_{1} = \textrm{H}\_{com}(R\_{1}) $ and sends commitment $t_{1}$ to all other cosigners.
The signer generates a random $ r_{1}\leftarrow\mathbb{Z_{\mathrm{p}}} $, which is termed the private nonce, computes $ R_{1} = g^{r_{1}} $ (the public nonce) and $ t_{1} = \textrm{H}\_{com}(R\_{1}) $ and sends commitment $t_{1}$ to all other cosigners.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The signer generates a random $ r_{1}\leftarrow\mathbb{Z_{\mathrm{p}}} $, which is termed the private nonce, computes $ R_{1} = g^{r_{1}} $ (the public nonce) and $ t_{1} = \textrm{H}\_{com}(R\_{1}) $ and sends commitment $t_{1}$ to all other cosigners.
The signer generates a random private nonce $ r_{1}\leftarrow\mathbb{Z_{\mathrm{p}}} $, computes $ R_{1} = g^{r_{1}} $ (the public nonce) and commitment $ t_{1} = \textrm{H}\_{com}(R\_{1}) $ and sends $t_{1}$ to all other cosigners.

@hansieodendaal hansieodendaal merged commit 065b7d5 into master Feb 15, 2019
@hansieodendaal hansieodendaal deleted the ks-musig-presentation branch February 15, 2019 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants