Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prover can panic on inconsistent input data #99

Closed
AaronFeickert opened this issue Oct 23, 2023 · 0 comments · Fixed by #100
Closed

Prover can panic on inconsistent input data #99

AaronFeickert opened this issue Oct 23, 2023 · 0 comments · Fixed by #100

Comments

@AaronFeickert
Copy link
Contributor

AaronFeickert commented Oct 23, 2023 •
edited

It's possible to cause the prover to panic by using a statement whose aggregation factor is inconsistent with its generators. This can be fixed by adding an additional prover consistency check. Another option is to make the prover more flexible in its handling of generators, to allow for the use of a larger generator set than is needed.
@AaronFeickert AaronFeickert mentioned this issue Oct 23, 2023
Merged
SWvheerden pushed a commit that referenced this issue Oct 25, 2023
@AaronFeickert
fix: don't panic on inconsistent generators (#100)
1f5c8a0 
Currently, the prover will panic if the statement aggregation factor
does not precisely correspond to that of the inner-product generators.
It would be best to allow the prover to use a larger generator set,
similarly to how the verifier operates, in order to be more flexible.
This PR adds such a fix, and includes a regression test.

Review of this PR should include asserting that removing the fix code
will fail the regression test.

Closes #99.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: don't panic on inconsistent generators AaronFeickert/bulletproofs-plus
1 participant
@AaronFeickert