fix: don't panic on inconsistent generators #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronFeickert
force-pushed
the
prover-generator-fix
branch
from
977ece3
to
5c09da7
Compare
AaronFeickert
changed the title
SWvheerden
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the prover will panic if the statement aggregation factor does not precisely correspond to that of the inner-product generators. It would be best to allow the prover to use a larger generator set, similarly to how the verifier operates, in order to be more flexible. This PR adds such a fix, and includes a regression test.
Review of this PR should include asserting that removing the fix code will fail the regression test.
Closes #99.