fix: improve prover consistency checks #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronFeickert
force-pushed
the
prover-consistency
branch
from
b164e85
to
8b4ea49
Compare
SWvheerden
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When producing a proof, the prover does not currently check that the provided witness value is within the range specified by the statement bit length. It also does not check that the witness corresponds to valid openings of the statement commitments. This is not a security issue (the verifier will reject such an invalid proof), but it means that the caller may produce an invalid proof that does not return an error.
This PR adds these checks, and ensures that the prover returns an error if they fail. It also adds unit tests exercising various failure modes.
Closes #97.