feat: range proof proving efficiency #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronFeickert
force-pushed
the
range-proving-complexity
branch
from
b5c6ca8
to
054dd8c
Compare
CjS77
approved these changes
Sep 14, 2023
CjS77
pushed a commit
that referenced
this pull request
Dec 19, 2023
Description --- Adds a brief note about range proof proving efficiency. Adds rough benchmarks against Bulletproofs. Motivation and Context --- It was [suggested](#103 (comment)) to add information about proving efficiency to range proof [RFC-0181](https://rfc.tari.com/RFC-0181_BulletproofsPlus.html). Quantifying proving efficiency is more subtle than verification efficiency, since proof generation doesn't reduce to a multiscalar multiplication operation and requires a variable number of rounds. Instead of bogging down the RFC with a long list of group element operation counts, this PR adds a more general note. Informal benchmark comparing the [Tari implementation](https://github.com/tari-project/bulletproofs-plus) to the [corresponding Bulletproofs fork](https://github.com/tari-project/bulletproofs) are included. How Has This Been Tested? --- The changes build and appear to render correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a brief note about range proof proving efficiency. Adds rough benchmarks against Bulletproofs.
Motivation and Context
It was suggested to add information about proving efficiency to range proof RFC-0181.
Quantifying proving efficiency is more subtle than verification efficiency, since proof generation doesn't reduce to a multiscalar multiplication operation and requires a variable number of rounds. Instead of bogging down the RFC with a long list of group element operation counts, this PR adds a more general note.
Informal benchmark comparing the Tari implementation to the corresponding Bulletproofs fork are included.
How Has This Been Tested?
The changes build and appear to render correctly.