fix: dont initially register automatically #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stringhandler
approved these changes
Feb 15, 2023
|
Feels much better. If needed we can create a cli arg or config |
sdbondi
added a commit
to sdbondi/tari-dan
that referenced
this pull request
Feb 15, 2023
* development: fix: dont initially register automatically (tari-project#372)
sdbondi
added a commit
to sdbondi/tari-dan
that referenced
this pull request
Feb 15, 2023
* development: fix: dont dial local shards if epoch manager has not synced (tari-project#370) fix: allow web UI to use OS-assigned JRPC address (tari-project#371) fix: dont initially register automatically (tari-project#372) fix: dont dial local shards if epoch manager has not synced (tari-project#369)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Validator will not register the first time automatically until user has initiated registration via the UI/JRPC
Motivation and Context
Potentially controversial: If auto_register = true, the validator would immediately try to register. If a user has this flag on (perhaps unintentionally) but does not intend to spend significant funds on registration, either because they are not ready, dont have funds, they only want the VN to observe the network, or for any other reason. They should have to explicitly initiate a registration via the UI/CLI and thereafter only let auto-registration take care of ensuring the VN stays registered.
How Has This Been Tested?
Manually, auto registration happens after initial has been done in web UI