Skip to content

Commit

Permalink
fix: fix cucumber test for standard recovery (#3757)
Browse files Browse the repository at this point in the history
Description
---
A recent fix to a major bug in the key manager that meant branching wasn’t being used broke the `Multiple Wallet recovery from seed node` cucumber test. This was because the test was trying to recover coinbases outputs whose keys are from a different branch in the key manager.

This PR fixes the `Wallet recovery with connected base node staying online` cucumber test to test recovering conventional outputs and marks `Wallet recovery with connected base node staying online` and `As a client I want to be able to restore my ffi wallet from seed words`as broken. They will be addressed by the team soon.
  • Loading branch information
philipr-za committed Jan 26, 2022
1 parent e61ec9d commit 1d58977
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 8 deletions.
2 changes: 1 addition & 1 deletion integration_tests/features/WalletFFI.feature
Expand Up @@ -21,7 +21,7 @@ Feature: Wallet FFI
And I want to get emoji id of ffi wallet FFI_WALLET
And I stop ffi wallet FFI_WALLET

@critical
@broken
Scenario: As a client I want to be able to restore my ffi wallet from seed words
Given I have a base node BASE
And I have wallet SPECTATOR connected to base node BASE
Expand Down
19 changes: 12 additions & 7 deletions integration_tests/features/WalletRecovery.feature
@@ -1,25 +1,30 @@
@wallet-recovery @wallet
Feature: Wallet Recovery

# TODO: having multiple wallet with the same network id is problematic, use N separate wallets or ensure that both are not trying to connect to the same base node
@broken
@critical
Scenario: Wallet recovery with connected base node staying online
Given I have a seed node NODE
And I have 1 base nodes connected to all seed nodes
And I have wallet WALLET_A connected to all seed nodes
And I have wallet WALLET_C connected to all seed nodes
And I have wallet WALLET_B connected to all seed nodes
And I have mining node MINER connected to base node NODE and wallet WALLET_A
When mining node MINER mines 10 blocks
When I mine 5 blocks on NODE
When I wait for wallet WALLET_A to have at least 55000000000 uT
Then all nodes are at height 15
When I recover wallet WALLET_A into wallet WALLET_B connected to all seed nodes
Then wallet WALLET_A and wallet WALLET_B have the same balance
And I send 100000 uT from wallet WALLET_B to wallet WALLET_C at fee 100
And I send 200000 uT from wallet WALLET_A to wallet WALLET_B at fee 100
When I mine 5 blocks on NODE
Then all nodes are at height 20
Then I wait for wallet WALLET_C to have at least 100000 uT
Then I stop wallet WALLET_B
When I recover wallet WALLET_B into wallet WALLET_C connected to all seed nodes
When I wait for wallet WALLET_C to have at least 200000 uT
And I have wallet WALLET_D connected to all seed nodes
And I send 100000 uT from wallet WALLET_C to wallet WALLET_D at fee 100
When I mine 5 blocks on NODE
Then all nodes are at height 25
Then I wait for wallet WALLET_D to have at least 100000 uT

@broken
Scenario Outline: Multiple Wallet recovery from seed node
Given I have a seed node NODE
And I have wallet WALLET_A connected to all seed nodes
Expand Down

0 comments on commit 1d58977

Please sign in to comment.