Skip to content

Commit

Permalink
feat: add default message tag (#6355)
Browse files Browse the repository at this point in the history
Description
---
Add a default message tag to `FinalSendMessageParams`. This enables the
tracing of ping-pong and other messages across nodes.

Motivation and Context
---
- We have a related issue with ping-pong, see #6356. This tracing will
assist in analysing the issue.
- With transaction testing, we noticed that some messages have a zero
tag; this will also help that tracing.

How Has This Been Tested?
---
System-level tests.

What process can a PR reviewer use to test or verify this change?
---
Review code.

<!-- Checklist -->
<!-- 1. Is the title of your PR in the form that would make nice release
notes? The title, excluding the conventional commit
tag, will be included exactly as is in the CHANGELOG, so please think
about it carefully. -->


Breaking Changes
---

- [x] None
- [ ] Requires data directory on base node to be deleted
- [ ] Requires hard fork
- [ ] Other - Please specify

<!-- Does this include a breaking change? If so, include this line as a
footer -->
<!-- BREAKING CHANGE: Description what the user should do, e.g. delete a
database, resync the chain -->
  • Loading branch information
hansieodendaal committed May 27, 2024
1 parent bc2ac4c commit ef387d7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion comms/dht/src/outbound/message_params.rs
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ impl Default for FinalSendMessageParams {
is_discovery_enabled: false,
dht_header: None,
debug_info: None,
tag: None,
tag: Some(MessageTag::new()),
}
}
}
Expand Down

0 comments on commit ef387d7

Please sign in to comment.