Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if a pending inbound transaction Output is in the chain before cancelling #2159

Closed
philipr-za opened this issue Aug 24, 2020 · 2 comments
Assignees
Labels
C-proposal Before becoming formal RFCs, new ideas are written up as proposals and discussed in the community

Comments

@philipr-za
Copy link
Contributor

Currently we will cancel a pending transaction if it has not completed after 3 days. However for an inbound transaction it is possible that a problem resulted in the Sender publishing the transaction but the Finalized message not reaching us. So before we totally give up on the transaction we should check with a Base Node if our output happened to be mined.

Waiting for Base Node RPC to be completed.

Related to #2137

@philipr-za philipr-za added the C-proposal Before becoming formal RFCs, new ideas are written up as proposals and discussed in the community label Aug 24, 2020
@stringhandler
Copy link
Collaborator

@philipr-za can this be closed?

@SWvheerden SWvheerden self-assigned this Aug 16, 2022
@SWvheerden
Copy link
Collaborator

SWvheerden commented Aug 16, 2022

Closing this.
Although we don't do an explicit check here when we cancel a transaction, we can only really check for the single outputs we own. If we can communicate with the exact wallet that finalized the transaction, we cannot recreate the kernel fields etc.
We can scan for the output, but since: #4464, we scan each block for outputs anyway. If an output goes missing from an erroneously canceled transaction, the utxo scanner will pick it up and add it to the OMS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-proposal Before becoming formal RFCs, new ideas are written up as proposals and discussed in the community
Projects
Archived in project
Development

No branches or pull requests

3 participants