Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wallet always scan interactive payments (see #4452) #4464

Conversation

jorgeantonio21
Copy link
Contributor

Description
--- Wallet should always scan for interactive payments.

Motivation and Context
--- See issue #4452.

How Has This Been Tested?
--- Unit tests

sdbondi
sdbondi previously approved these changes Aug 12, 2022
Copy link
Member

@sdbondi sdbondi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this with 2 wallets, same pk different tor, and apart from the wallets kicking each other off the network, the scanning now picks up standard outputs successfully

@SWvheerden
Copy link
Collaborator

Fixes: #4452

@SWvheerden
Copy link
Collaborator

This looks good, just fix that log entry in standard_outputs_recoverer.rs ln 158

@jorgeantonio21 jorgeantonio21 marked this pull request as ready for review August 15, 2022 10:51
@jorgeantonio21
Copy link
Contributor Author

jorgeantonio21 commented Aug 15, 2022

This looks good, just fix that log entry in standard_outputs_recoverer.rs ln 158

@SWvheerden, I removed the log

Copy link
Collaborator

@SWvheerden SWvheerden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aviator-app aviator-app bot merged commit 0c595dd into tari-project:development Aug 16, 2022
sdbondi added a commit to sdbondi/tari that referenced this pull request Aug 16, 2022
…ld-selector

* development:
  fix: wrong ban reason (tari-project#4461)
  fix broken critical cucumber test (tari-project#4458)
  chore: remove Defunct L2 code (tari-project#4463)
  fix(ci): binary builds - remove tari_collectibles and lib deps for linux  (tari-project#4454)
  feat(docker) :build tari docker images for launchpad (tari-project#4476)
  fix: fix transaction output hashing (tari-project#4483)
  chore: remove broken tag from working tests (tari-project#4471)
  fix: wallet always scan interactive payments (see tari-project#4452) (tari-project#4464)
  feat: remove total_txs and rename total_weight in mempool (tari-project#4474)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants