Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check-title CI failed on a valid title #3254

Closed
delta1 opened this issue Aug 27, 2021 · 2 comments
Closed

check-title CI failed on a valid title #3254

delta1 opened this issue Aug 27, 2021 · 2 comments

Comments

@delta1
Copy link
Contributor

delta1 commented Aug 27, 2021

The valid PR title "feat(base_node): prompt user to create id if not found" failed on this PR: #3245

The error message was:

image

I suspect that the PR title being passed to "echo" needs to be surrounded with quotes (which worked locally for me)
@delta1
Copy link
Contributor Author

delta1 commented Aug 27, 2021

Confirming it's a bash error

# echo feat(base_node): prompt user to create id if not found
bash: syntax error near unexpected token `('

delta1 pushed a commit to delta1/tari that referenced this issue Aug 31, 2021
fix(ci): add quotes to pr title ci
29247c2 
issue tari-project#3254
@delta1 delta1 mentioned this issue Aug 31, 2021
Closed
@delta1
Copy link
Contributor Author

delta1 commented Aug 31, 2021

Fixed in #3273

@delta1 delta1 closed this as completed Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@delta1