feat: merge consensus breaking changes in #3195 #3193 with weatherwax compatibility #3372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stringhandler
previously approved these changes
Sep 21, 2021
sdbondi
force-pushed
the
igor
branch
2 times, most recently
from
94ba3d9
to
bcd2a4f
Compare
Co-authored-by: Stan Bondi <sdbondi@users.noreply.github.com>
Block v1 (compatible with weatherwax at all heights): - Kernel ordering using every kernel field - Input MR commits to empty serialization of bitmap Block v2 (Igor, breaking change) - Kernel ordering (tari-project#3193) - Input MR uses input hashes only without extaneous empty bitmap bytes (tari-project#3195)
stringhandler
approved these changes
Sep 21, 2021
This was referenced Sep 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Block v1 (compatible with weatherwax at all heights):
Block v2 (Igor, breaking change)
([DO NOT MERGE] fix: fix input_mmr type #3195)
Misc
Motivation and Context
Allow consensus breaking code to be merged without hard forking weatherwax.
Igor will have to be reset.
To follow in subsequent PR: network breaking changes from DHT header malleability fix (#3243 )
How Has This Been Tested?
Archival sync weatherwax node from scratch, received propagated blocks
Washing machine between two weatherwax wallets