feat!: make DhtHeader field non-malleable #3243
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delta1
previously approved these changes
Aug 24, 2021
philipr-za
force-pushed
the
philip-dht-header-map
branch
from
78a45ac
to
cf1b6d3
Compare
### Breaking Change to comms This PR includes the relevant DhtHeader fields in the commitment of a Dht Message MAC signature so that they cannot be changed while in route. The header fields included in the commitment are: - Major version - Minor version - Destination - Message type - Message flags - Expiry time (if exists) - Ephemeral public key (if exists)
philipr-za
force-pushed
the
philip-dht-header-map
branch
from
cf1b6d3
to
b8cc0a3
Compare
Ahh yes you are correct I should have incremented the DHT_MAJOR_VERSION and have updated that. |
philipr-za
changed the title
sdbondi
approved these changes
Aug 30, 2021
aviator-app bot
pushed a commit
that referenced
this pull request
Sep 21, 2021
… compatibility (#3372) Description --- Block v1 (compatible with weatherwax at all heights): - Kernel ordering using every kernel field - Input MR commits to empty serialization of bitmap Block v2 (Igor, breaking change) - Kernel ordering (#3193) - Input MR uses input hashes only without extaneous empty bitmap bytes (#3195) Misc - Add missing kernel order block validation - Removed unnecessary transaction body sorting in wallet, it (still) is the responsibility of the GetNewBlockTemplate to assemble a final sorted block body. Motivation and Context --- Allow consensus breaking code to be merged without hard forking weatherwax. Igor will have to be reset. To follow in subsequent PR: network breaking changes from DHT header malleability fix (#3243 ) How Has This Been Tested? --- Archival sync weatherwax node from scratch, received propagated blocks Washing machine between two weatherwax wallets
aviator-app bot
pushed a commit
that referenced
this pull request
Sep 22, 2021
Description --- - implements DHT protocol versioning allowing the same codebase to be used for multiple networks - DRY dht header signature construction - Pre-version 2 DHT protocol does not use the entire header in signature challenge - minor DHT builder improvements Motivation and Context --- Allow new break protocols to be introduced while old protocols still exist. Setting the protocol version sets the DHT to speak that version, while still supporting previous versions Closes #3243 How Has This Been Tested? --- Tested discovery on weatherwax which uses versioned challenge construction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes the relevant DhtHeader fields in the commitment of a Dht Message MAC signature so that they cannot be changed while in route.
The header fields included in the commitment are:
How Has This Been Tested?
Rust integration test provided and existing tests updated.
BREAKING CHANGE: Previous message signatures will not be valid