fix: remove unnecessary wallet dependency #3438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
curious, but it also related to #3427 and partially fixes it |
therustmonk
force-pushed
the
tari-error
branch
from
2218e3e
to
ed65f2a
Compare
sdbondi
previously approved these changes
Oct 11, 2021
therustmonk
force-pushed
the
tari-error
branch
2 times, most recently
from
329b391
to
1307bc8
Compare
|
rebased to |
therustmonk
force-pushed
the
tari-error
branch
from
1307bc8
to
1aecde2
Compare
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Oct 18, 2021
* development: fix: remove unnecessary wallet dependency (tari-project#3438) test: simplify cucumber tests (tari-project#3457)
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Oct 25, 2021
* development: (31 commits) feat!: revalidate all outputs (tari-project#3471) fix: check SAF message inflight and check stored_at is in past (tari-project#3444) feat!: apps should not depend on other app configs (tari-project#3469) fix: fix recovery test reporting message (tari-project#3479) chore: improve cucumber tests to wait for broadcast (tari-project#3461) test: use TCP node for daily sync test (tari-project#3464) fix: remove unbounded vec allocations from base node grpc/p2p messaging (tari-project#3467) fix: upgrade rustyline dependencies (tari-project#3476) fix(dht): discard encrypted message with no destination (tari-project#3472) fix: remove consensus breaking change in transaction input (tari-project#3474) feat: tx weight takes tariscript and output features into account [igor] (tari-project#3411) fix: validate dht header before dedup cache (tari-project#3468) fix: sha256sum isn't available on all *nix platforms (tari-project#3466) fix: typo in console wallet (tari-project#3465) fix: ensure that accumulated orphan chain data is committed before header validation (tari-project#3462) fix: remove is_synced check for transaction validation (tari-project#3459) feat: improve logging for tari_mining_node (tari-project#3449) fix: remove unnecessary wallet dependency (tari-project#3438) test: simplify cucumber tests (tari-project#3457) ci: create script to update DNS records from hashes.txt (tari-project#3458) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes
walletdependency fromtari_app_grpcandtari_app_utilities.Motivation and Context
grpcandutilitiesare common and don't contain relations with the wallet.Dependency has been removed because it affects building time and complicates maintenance.
How Has This Been Tested?
CI only, because the changes don't affect any feature and change locations of some types only.