feat: improve logging for tari_mining_node #3449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StriderDM
force-pushed
the
improve_miner_logging
branch
from
3132ae0
to
818849f
Compare
philipr-za
reviewed
Oct 13, 2021
There was a problem hiding this comment.
Tested this out and I have two comments:
Firstly, the stats are only displayed when a share is found and between finding a share there is no activity on the terminal at all. I would prefer a periodic output of the stats including the number of threads being used.
Secondly, the output is still linked to the log level of the miner directly. This means the log file also only has the minimal Info in it and if you change this level to Debug the terminal is flooded. Rather have a unique Target for the terminal output and then pipe the actual logs into the file.
StriderDM
force-pushed
the
improve_miner_logging
branch
from
818849f
to
4667e01
Compare
philipr-za
reviewed
Oct 15, 2021
|
It is (S/s), which is the share rate as seen in the pool UI. Only counting the solutions found rather than how many hashes the miner is doing. |
Def need to put hashrate, this is the key metric that a Miner cares about and tries to optimize. |
StriderDM
force-pushed
the
improve_miner_logging
branch
from
4667e01
to
5ec6cc1
Compare
This PR improves the logging for tari_mining_node by making use of the log4rs target, it also sets the default logging level to info. This PR also adds basic statistics for pool mining which are automatically displayed on a 20s interval. Review comments Add additional log target, split logging messages between terminal and file. Updated stratum miner to display basic statistics every 20 seconds instead of when changing jobs. Added info message to indicate hashing is in progress for stratum miner. Added hash rate to displayed statistics in additon to share rate. Included metric for share and hash rates. Error handling for rejected share
StriderDM
force-pushed
the
improve_miner_logging
branch
from
5ec6cc1
to
fbe17c7
Compare
philipr-za
approved these changes
Oct 18, 2021
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Oct 18, 2021
* development: fix: ensure that accumulated orphan chain data is committed before header validation (tari-project#3462) fix: remove is_synced check for transaction validation (tari-project#3459) feat: improve logging for tari_mining_node (tari-project#3449)
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Oct 18, 2021
* development: fix: ensure that accumulated orphan chain data is committed before header validation (tari-project#3462) fix: remove is_synced check for transaction validation (tari-project#3459) feat: improve logging for tari_mining_node (tari-project#3449)
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Oct 25, 2021
* development: (31 commits) feat!: revalidate all outputs (tari-project#3471) fix: check SAF message inflight and check stored_at is in past (tari-project#3444) feat!: apps should not depend on other app configs (tari-project#3469) fix: fix recovery test reporting message (tari-project#3479) chore: improve cucumber tests to wait for broadcast (tari-project#3461) test: use TCP node for daily sync test (tari-project#3464) fix: remove unbounded vec allocations from base node grpc/p2p messaging (tari-project#3467) fix: upgrade rustyline dependencies (tari-project#3476) fix(dht): discard encrypted message with no destination (tari-project#3472) fix: remove consensus breaking change in transaction input (tari-project#3474) feat: tx weight takes tariscript and output features into account [igor] (tari-project#3411) fix: validate dht header before dedup cache (tari-project#3468) fix: sha256sum isn't available on all *nix platforms (tari-project#3466) fix: typo in console wallet (tari-project#3465) fix: ensure that accumulated orphan chain data is committed before header validation (tari-project#3462) fix: remove is_synced check for transaction validation (tari-project#3459) feat: improve logging for tari_mining_node (tari-project#3449) fix: remove unnecessary wallet dependency (tari-project#3438) test: simplify cucumber tests (tari-project#3457) ci: create script to update DNS records from hashes.txt (tari-project#3458) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the logging for tari_mining_node by making use of the log4rs target, it also sets the default logging level to info.
This PR also adds basic statistics for pool mining which are automatically displayed at a 20s interval.
Motivation and Context
How Has This Been Tested?
Manually