feat(consensus)!: add tari script byte size limit check to validation #3640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
force-pushed
the
core-consensus-script-byte-size
branch
from
a074dd4
to
4daf021
Compare
* development: feat: bad block list for invalid blocks after sync (tari-project#3637)
delta1
approved these changes
Dec 6, 2021
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Dec 7, 2021
* development: feat(consensus)!: add tari script byte size limit check to validation (tari-project#3640) fix: minor improvements to available neighbouring peer search (tari-project#3598) feat: bad block list for invalid blocks after sync (tari-project#3637)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Breaking changes:
If an existing script is larger than 2048, that block/output will fail to validate on upgraded nodes. I have not explicitly checked this but the largest scripts used currently on testnet are one-sided payments and they are well within the limit.
Motivation and Context
See @CjS77 comment
TODO: Ideally, in order to not negatively impact validation performance, we should not have to serialise the script again to gain its byte size.
How Has This Been Tested?
New unit test, basic manual test