fix: minor improvements to available neighbouring peer search #3598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
force-pushed
the
comms-connectivity-remove-offline-peers
branch
5 times, most recently
from
45a0cb4
to
434a984
Compare
hansieodendaal
previously approved these changes
Nov 30, 2021
|
Going to work on various improvements to the strategy here, setting as draft |
sdbondi
force-pushed
the
comms-connectivity-remove-offline-peers
branch
from
434a984
to
ff90b86
Compare
sdbondi
force-pushed
the
comms-connectivity-remove-offline-peers
branch
8 times, most recently
from
c067fc6
to
fa598a5
Compare
sdbondi
changed the title
sdbondi
force-pushed
the
comms-connectivity-remove-offline-peers
branch
from
fa598a5
to
5ab6083
Compare
sdbondi
force-pushed
the
comms-connectivity-remove-offline-peers
branch
from
5ab6083
to
4937112
Compare
* development: feat: bad block list for invalid blocks after sync (tari-project#3637)
delta1
approved these changes
Dec 6, 2021
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Dec 7, 2021
* development: feat(consensus)!: add tari script byte size limit check to validation (tari-project#3640) fix: minor improvements to available neighbouring peer search (tari-project#3598) feat: bad block list for invalid blocks after sync (tari-project#3637)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
By removing peers from the peer manager when offline, the number of peers stored on the network should gradually decrease. This will only happen once all/most peers are upgraded.
How Has This Been Tested?
Memorynet
Manually, base node operates normally and peer list reduces (until peer sync pulls more in again from nodes without this change)