Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a gRPC interface in console wallet to set the connected base node #3821

Closed
philipr-za opened this issue Feb 10, 2022 · 1 comment · Fixed by #3828
Closed

Create a gRPC interface in console wallet to set the connected base node #3821

philipr-za opened this issue Feb 10, 2022 · 1 comment · Fixed by #3828
Labels
A-wallet Area - related to the wallet E-good_first_issue Experience Level - Good for newcomers

Comments

@philipr-za
Copy link
Contributor

Address the following TODO in the code:

// TODO gRPC interfaces for setting base node

clear TODO comment when completed
@philipr-za philipr-za added E-good_first_issue Experience Level - Good for newcomers A-wallet Area - related to the wallet labels Feb 10, 2022
zhangcheng added a commit to zhangcheng/tari that referenced this issue Feb 13, 2022
@zhangcheng
try to fix tari-project#3821
6016404
@zhangcheng
Copy link
Contributor

zhangcheng commented Feb 13, 2022 •
edited
Loading

I just took a crack on this.
@philipr-za pls take a look at the attached PR (#3828), does this align with your idea for this ticket?
I am new to Tari, gRPC and Rust, feedback is very welcome.

Also, I don't know how to write a proper unit test for this yet.

zhangcheng added a commit to zhangcheng/tari that referenced this issue Feb 14, 2022
@zhangcheng
feat(wallet): add grpc method for setting base node
b1091c9 
Description
---
Aim to resolve tari-project#3821

Motivation and Context
---
Learning via "good first issue"

How Has This Been Tested?
---
Code compiles
@zhangcheng zhangcheng mentioned this issue Feb 14, 2022
Merged
zhangcheng added a commit to zhangcheng/tari that referenced this issue Feb 14, 2022
@zhangcheng
feat(wallet): add grpc method for setting base node
9fbe1e7 
Description
---
Aim to resolve tari-project#3821

Motivation and Context
---
Learning via "good first issue"

How Has This Been Tested?
---
Manual test with `grpcurl`
hansieodendaal pushed a commit to hansieodendaal/tari that referenced this issue Feb 14, 2022
@zhangcheng
feat(wallet): add grpc method for setting base node (tari-project#3828)
8791e93 
Description
---
Aim to resolve tari-project#3821

Motivation and Context
---
Learning via "good first issue"

How Has This Been Tested?
---
Code compiles, and manual test with `grpcurl`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-wallet Area - related to the wallet E-good_first_issue Experience Level - Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(wallet): add grpc method for setting base node zhangcheng/tari
3 participants
@zhangcheng @stringhandler @philipr-za