Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate removal of derived Serialized/Deserialized and Debug traits for UnblindedOuput and RawTransactionInfo #3822

Closed
philipr-za opened this issue Feb 10, 2022 · 0 comments
Closed

Investigate removal of derived Serialized/Deserialized and Debug traits for UnblindedOuput and RawTransactionInfo #3822

philipr-za opened this issue Feb 10, 2022 · 0 comments
Assignees
@Cifko
Labels
A-security Area - Security related A-transaction_sending Area - related to sending transactions
Milestone
Stagenet Freeze

Comments

@philipr-za
Copy link
Contributor

As per the TODO comments investigate if we can get rid of these implementations as they can potentially leak private data.

I believe the Serialize/Deserialize will need to stay as they are using for database storage but the Debug trait should be removed.

Remove TODO's when done

// TODO: Try to get rid of 'Serialize' and 'Deserialize' traits here; see related comment at 'struct RawTransactionInfo' #LOGGED

// TODO: Investigate necessity to use the 'Serialize' and 'Deserialize' traits here; this could potentially leak
// TODO: information when least expected. #LOGGED
@therustmonk therustmonk mentioned this issue Jul 6, 2022
Merged
stringhandler pushed a commit to tari-project/tari-crypto that referenced this issue Jul 22, 2022
@therustmonk
fix: don't print a secret key by default (#112)
45c5728 
Fixes for tari-project/tari#3822
Secret keys will never be printed until they are revealed explicitly with the `.reveal()` method call.
@stringhandler stringhandler added this to the Stagenet Freeze milestone Nov 15, 2022
@stringhandler stringhandler added A-security Area - Security related A-transaction_sending Area - related to sending transactions labels Nov 15, 2022
@Cifko Cifko self-assigned this Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Cifko Cifko

Labels
A-security Area - Security related A-transaction_sending Area - related to sending transactions
Projects
Tari Esme Testnet
Archived in project
Milestone
Stagenet Freeze
Development

No branches or pull requests
3 participants
@stringhandler @philipr-za @Cifko