Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bug in block timing grpc method #3926

Merged
merged 12 commits into from
Mar 24, 2022
Merged

fix: bug in block timing grpc method #3926

merged 12 commits into from
Mar 24, 2022

Conversation

delta1
Copy link
Contributor

@delta1 delta1 commented Mar 17, 2022

Description

  • Fixes a bug where the grpc method for block timing was requesting the headers in the wrong order, resulting in wrong calculation
  • Removes the deprecated duplicate GetCalcTiming method
  • Un-ignores the chain balance test which is working again

sdbondi
sdbondi reviewed Mar 21, 2022
View reviewed changes
Copy link
Member

@sdbondi sdbondi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - some minor comments

base_layer/core/src/blocks/block_header.rs Outdated Show resolved Hide resolved
base_layer/core/src/blocks/block_header.rs Outdated Show resolved Hide resolved
base_layer/core/src/blocks/block_header.rs Outdated Show resolved Hide resolved
@aviator-app aviator-app bot merged commit 1c7adc0 into tari-project:development Mar 24, 2022
@delta1 delta1 deleted the block-timing-fix branch March 24, 2022 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdbondi sdbondi sdbondi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@delta1 @sdbondi